blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

Fix T92180: Curve subdivide incorrect result for poly splines 

The node shifted all new points forward in the spline, so the first
point would appear to be removed.
This commit is contained in:
Hans Goudey 2021-10-13 14:28:05 -05:00
parent 10abaf3ddf
commit 1ae79b704a
Notes: blender-bot 2023-02-14 10:11:54 +01:00 
Referenced by issue #92180, Subdivide Curve Node: Shifts First Point Position
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc
View File

@ -63,9 +63,9 @@ static void subdivide_attribute(Span<T> src,
for (const int i : range) {
const int cuts = offsets[i + 1] - offsets[i];
dst[offsets[i]] = src[i];
const float factor_delta = 1.0f / (cuts + 1.0f);
const float factor_delta = cuts == 0 ? 1.0f : 1.0f / cuts;
for (const int cut : IndexRange(cuts)) {
const float factor = (cut + 1) * factor_delta;
const float factor = cut * factor_delta;
dst[offsets[i] + cut] = attribute_math::mix2(factor, src[i], src[i + 1]);
}
}
@ -75,9 +75,9 @@ static void subdivide_attribute(Span<T> src,
const int i = src_size - 1;
const int cuts = offsets[i + 1] - offsets[i];
dst[offsets[i]] = src.last();
const float factor_delta = 1.0f / (cuts + 1.0f);
const float factor_delta = cuts == 0 ? 1.0f : 1.0f / cuts;
for (const int cut : IndexRange(cuts)) {
const float factor = (cut + 1) * factor_delta;
const float factor = cut * factor_delta;
dst[offsets[i] + cut] = attribute_math::mix2(factor, src.last(), src.first());
}
}