blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

Fix T67060 EEVEE: Noise caused by disk lights 

This is an issue on some drivers that might output NaN out of sqrt if the
number is infinity.
This commit is contained in:
Clément Foucault 2020-01-29 00:32:45 +01:00
parent f9e1e088a4
commit 3d73609832
Notes: blender-bot 2023-02-14 11:00:17 +01:00 
Referenced by issue #67060, Noise in material preview
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/draw/engines/eevee/shaders/bsdf_common_lib.glsl
View File

@ -5,6 +5,7 @@
#define M_1_PI 0.318309886183790671538 /* 1/pi */
#define M_1_2PI 0.159154943091895335768 /* 1/(2*pi) */
#define M_1_PI2 0.101321183642337771443 /* 1/(pi^2) */
#define FLT_MAX 3.402823e+38
#define LUT_SIZE 64

7
source/blender/draw/engines/eevee/shaders/ltc_lib.glsl
View File

@ -54,6 +54,9 @@ vec3 solve_cubic(vec4 coefs)
/* Discriminant */
float discr = dot(vec2(4.0 * delta.x, -delta.y), delta.zy);
/* Clamping avoid NaN output on some platform. (see T67060) */
float sqrt_discr = sqrt(clamp(discr, 0.0, FLT_MAX));
vec2 xlc, xsc;
/* Algorithm A */
@ -63,7 +66,7 @@ vec3 solve_cubic(vec4 coefs)
float D_a = -2.0 * B * delta.x + delta.y;
/* Take the cubic root of a normalized complex number */
float theta = atan(sqrt(discr), -D_a) / 3.0;
float theta = atan(sqrt_discr, -D_a) / 3.0;
float x_1a = 2.0 * sqrt(-C_a) * cos(theta);
float x_3a = 2.0 * sqrt(-C_a) * cos(theta + (2.0 / 3.0) * M_PI);
@ -86,7 +89,7 @@ vec3 solve_cubic(vec4 coefs)
float D_d = -D * delta.y + 2.0 * C * delta.z;
/* Take the cubic root of a normalized complex number */
float theta = atan(D * sqrt(discr), -D_d) / 3.0;
float theta = atan(D * sqrt_discr, -D_d) / 3.0;
float x_1d = 2.0 * sqrt(-C_d) * cos(theta);
float x_3d = 2.0 * sqrt(-C_d) * cos(theta + (2.0 / 3.0) * M_PI);