blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix T38863: FCurve auto-clamp allows handle to move past X bounds 

F-Curves with large Y axis had strange behavior where the handles could
stretch out on the X axis rather then clamping as they do at smaller sizes.
This commit is contained in:
Campbell Barton 2014-02-27 17:15:49 +11:00
parent 55fe91abf3
commit 4622fc418e
Notes: blender-bot 2023-02-14 11:07:28 +01:00 
Referenced by issue #38863, FCurve auto-clamp allows handle to move past X bounds.
Referenced by issue #38817, Fcurve snapping and autoclamp error
1 changed files with 29 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
source/blender/blenkernel/intern/curve.c
View File

@ -3024,24 +3024,38 @@ static void calchandleNurb_intern(BezTriple *bezt, BezTriple *prev, BezTriple *n
}
}
if (leftviolate || rightviolate) { /* align left handle */
float h1[3], h2[3];
float dot;
if (mode != 0) {
/* simple 2d calculation */
float h1_x = p2_h1[0] - p2[0];
float h2_x = p2[0] - p2_h2[0];
sub_v3_v3v3(h1, p2_h1, p2);
sub_v3_v3v3(h2, p2, p2_h2);
len_a = normalize_v3(h1);
len_b = normalize_v3(h2);
dot = dot_v3v3(h1, h2);
if (leftviolate) {
mul_v3_fl(h1, dot * len_b);
sub_v3_v3v3(p2_h2, p2, h1);
if (leftviolate) {
p2_h2[1] = p2[1] + ((p2[1] - p2_h1[1]) / h1_x) * h2_x;
}
else {
p2_h1[1] = p2[1] + ((p2[1] - p2_h2[1]) / h2_x) * h1_x;
}
}
else {
mul_v3_fl(h2, dot * len_a);
add_v3_v3v3(p2_h1, p2, h2);
float h1[3], h2[3];
float dot;
sub_v3_v3v3(h1, p2_h1, p2);
sub_v3_v3v3(h2, p2, p2_h2);
len_a = normalize_v3(h1);
len_b = normalize_v3(h2);
dot = dot_v3v3(h1, h2);
if (leftviolate) {
mul_v3_fl(h1, dot * len_b);
sub_v3_v3v3(p2_h2, p2, h1);
}
else {
mul_v3_fl(h2, dot * len_a);
add_v3_v3v3(p2_h1, p2, h2);
}
}
}
}