Fix T74096: Paint Masking overlay can`t be hidden

Caused by rB9516921c05bd.

Dont really see a reason to draw overlays here if overlays are disabled.
Looks like this only affects Face/Vertex mask selection drawing [which
should indeed be hidden when overlays are disabled] next to two
exceptions:

- OVERLAY_paint_vertex_cache_populate draws weights as well [D7176 /
T70807 might be related here, but to me it looks like drawing weights
here is actually not needed at all]

- OVERLAY_paint_texture_cache_populate calls
DRW_cache_mesh_surface_texpaint_get [not sure about this one, this is
also called from workbench_cache_texpaint_populate, looks like this is
not needed when overlays are hidden]

Maniphest Tasks: T74096

Differential Revision: https://developer.blender.org/D7179
This commit is contained in:
Philipp Oeser 2020-03-18 19:19:12 +01:00
parent 6e4eb2be28
commit 579447bd89
Notes: blender-bot 2023-02-14 08:25:14 +01:00
Referenced by issue #74096, Texture paint. Masking overlay can`t be hidden (regression bug)
1 changed files with 1 additions and 1 deletions

View File

@ -304,7 +304,7 @@ static void OVERLAY_cache_populate(void *vedata, Object *ob)
else if (in_pose_mode && draw_bones) {
OVERLAY_pose_armature_cache_populate(vedata, ob);
}
else if (in_paint_mode) {
else if (in_paint_mode && !pd->hide_overlays) {
switch (draw_ctx->object_mode) {
case OB_MODE_VERTEX_PAINT:
OVERLAY_paint_vertex_cache_populate(vedata, ob);