blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 751 Projects 19 Wiki Activity

Fix T84780: Corrupt screen layout when loading file with area full-screen 

This could happen with files saved before ef4aa42ea4, so before global areas
were written to .blend files.
We would just always add the top- and status-bar, even though the screen wasn't
supposed to have them. I'm not entirely sure what caused the further issues
observed there, most code should probably handle the case fine still. But
apparently something didn't.

Steps to reproduce were:
* Open Blender from before ef4aa42ea4 (e.g 2.91 release)
* In 3D View, View > Area > Toggle Fullscreen Area
* Save the file
* Open the saved file (can be in newer version too)
The fullscreen is corrupt now, especially noticable after duplicating the
workspace.
This commit is contained in:
Julian Eisel 2021-02-01 00:40:15 +01:00
parent fa2ffb1a2f
commit 5c72a4d452
Notes: blender-bot 2023-02-14 05:04:52 +01:00 
Referenced by issue #84780, "Layout" workspace in attached file seems corrupted. The option to split panel is gone, and menus open but don't close!
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/editors/screen/screen_edit.c
View File

@ -871,6 +871,11 @@ static void screen_global_area_refresh(wmWindow *win,
const short height_min,
const short height_max)
{
/* Full-screens shouldn't have global areas. Don't touch them. */
if (screen->state == SCREENFULL) {
return;
}
ScrArea *area = NULL;
LISTBASE_FOREACH (ScrArea *, area_iter, &win->global_areas.areabase) {
if (area_iter->spacetype == space_type) {