Cleanup: Slightly improve mesh normals and runtime comments
Also resolved an unused variable warning caused by an earlier cleanup.
This commit is contained in:
parent
89ca298210
commit
6cf4999e50
|
@ -381,15 +381,16 @@ const float (*BKE_mesh_poly_normals_ensure(const struct Mesh *mesh))[3];
|
|||
void BKE_mesh_normals_tag_dirty(struct Mesh *mesh);
|
||||
|
||||
/**
|
||||
* Check that a mesh with non-dirty normals has vertex and face custom data layers.
|
||||
* Check that a mesh with non-dirty normals has the caches allocatred with a proper size.
|
||||
* If these asserts fail, it means some area cleared the dirty flag but didn't copy or add the
|
||||
* normal layers, or removed normals but didn't set the dirty flag.
|
||||
* normals, or removed normals but didn't set the dirty flag.
|
||||
*/
|
||||
void BKE_mesh_assert_normals_dirty_or_calculated(const struct Mesh *mesh);
|
||||
|
||||
/**
|
||||
* Retrieve write access to the vertex normal layer, ensuring that it exists and that it is not
|
||||
* shared. The provided vertex normals should be the same as if they were calculated automatically.
|
||||
* Retrieve write access to the cached vertex normals, ensuring that they are allocated but *not*
|
||||
* that they are calculated. The provided vertex normals should be the same as if they were
|
||||
* calculated automatically.
|
||||
*
|
||||
* \note In order to clear the dirty flag, this function should be followed by a call to
|
||||
* #BKE_mesh_vertex_normals_clear_dirty. This is separate so that normals are still tagged dirty
|
||||
|
@ -401,8 +402,9 @@ void BKE_mesh_assert_normals_dirty_or_calculated(const struct Mesh *mesh);
|
|||
float (*BKE_mesh_vertex_normals_for_write(struct Mesh *mesh))[3];
|
||||
|
||||
/**
|
||||
* Retrieve write access to the poly normal layer, ensuring that it exists and that it is not
|
||||
* shared. The provided poly normals should be the same as if they were calculated automatically.
|
||||
* Retrieve write access to the cached polygon normals, ensuring that they are allocated but *not*
|
||||
* that they are calculated. The provided polygon normals should be the same as if they were
|
||||
* calculated automatically.
|
||||
*
|
||||
* \note In order to clear the dirty flag, this function should be followed by a call to
|
||||
* #BKE_mesh_poly_normals_clear_dirty. This is separate so that normals are still tagged dirty
|
||||
|
|
|
@ -226,7 +226,6 @@ bool BKE_mesh_runtime_ensure_edit_data(struct Mesh *mesh)
|
|||
if (mesh->runtime->edit_data != nullptr) {
|
||||
return false;
|
||||
}
|
||||
|
||||
mesh->runtime->edit_data = MEM_cnew<EditMeshData>(__func__);
|
||||
return true;
|
||||
}
|
||||
|
@ -250,6 +249,7 @@ void BKE_mesh_runtime_clear_cache(Mesh *mesh)
|
|||
|
||||
void BKE_mesh_runtime_clear_geometry(Mesh *mesh)
|
||||
{
|
||||
/* Tagging shared caches dirty will free the allocated data if there is only one user. */
|
||||
free_bvh_cache(*mesh->runtime);
|
||||
free_normals(*mesh->runtime);
|
||||
free_subdiv_ccg(*mesh->runtime);
|
||||
|
|
|
@ -246,7 +246,7 @@ static void read_mpolys(CDStreamConfig &config, const AbcMeshData &mesh_data)
|
|||
}
|
||||
}
|
||||
|
||||
static void process_no_normals(CDStreamConfig &config)
|
||||
static void process_no_normals(CDStreamConfig & /*config*/)
|
||||
{
|
||||
/* Absence of normals in the Alembic mesh is interpreted as 'smooth'. */
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue