Fix T81854: crash when undoing switch between sculpt and edit mode.
The logic of `BKE_sculpt_update_object_for_edit` was not correct. such low-level functions should typically never preform depsgraph evaluation themselves, they should be able to rely on getting a fully evaluated depsgraph and just get needed data from there. Supporting that required fixing other broken code higher in the callstack, namely: * `ED_object_sculptmode_enter_ex` was freeing evaluated data, for no valid reason it would seem. * `sculpt_undosys_step_decode` was ensuring an evaluated depsgraph **before** calling `ED_object_mode_generic_exit`, which would invalidate a lot of evaluated data. Note that it is fairly difficult to track down all code paths leading to `BKE_sculpt_update_object_for_edit`, so there may be still cases where this gets called with improperly evaluated depsgraph. Reviewed By: sergey Maniphest Tasks: T81854 Differential Revision: https://developer.blender.org/D9270
This commit is contained in:
parent
f6990c235a
commit
90e12e823f
Notes:
blender-bot
2023-02-14 06:00:46 +01:00
Referenced by commit14a893f20e
, Fix T98225: file saved with an object in sculptmode that is disabled in viewports crashes on reload Referenced by commitd29a720c45
, Fix T84002: Sculpt: Masking operations crash if multires is in play. Referenced by issue #98225, Regression: file saved with an object in sculptmode that is disabled in viewports crashes on reload Referenced by issue #84002, Sculpt: Masking operations crash if multires is in play Referenced by issue #81854, Crash in undoing switch from sculpt to edit mode and back. Referenced by issue #77348, Blender LTS: Maintenance Task 2.83
|
@ -1734,17 +1734,16 @@ void BKE_sculpt_color_layer_create_if_needed(struct Object *object)
|
|||
DEG_id_tag_update(&orig_me->id, ID_RECALC_GEOMETRY);
|
||||
}
|
||||
|
||||
/** \warning Expects a fully evaluated depsgraph. */
|
||||
void BKE_sculpt_update_object_for_edit(
|
||||
Depsgraph *depsgraph, Object *ob_orig, bool need_pmap, bool need_mask, bool need_colors)
|
||||
{
|
||||
/* Update from sculpt operators and undo, to update sculpt session
|
||||
* and PBVH after edits. */
|
||||
Scene *scene_eval = DEG_get_evaluated_scene(depsgraph);
|
||||
Object *ob_eval = DEG_get_evaluated_object(depsgraph, ob_orig);
|
||||
Mesh *me_eval = mesh_get_eval_final(depsgraph, scene_eval, ob_eval, &CD_MASK_BAREMESH);
|
||||
|
||||
BLI_assert(ob_orig == DEG_get_original_object(ob_orig));
|
||||
|
||||
Object *ob_eval = DEG_get_evaluated_object(depsgraph, ob_orig);
|
||||
Mesh *me_eval = BKE_object_get_evaluated_mesh(ob_eval);
|
||||
BLI_assert(me_eval != NULL);
|
||||
|
||||
sculpt_update_object(depsgraph, ob_orig, me_eval, need_pmap, need_mask, need_colors);
|
||||
}
|
||||
|
||||
|
|
|
@ -8133,6 +8133,7 @@ static void SCULPT_OT_symmetrize(wmOperatorType *ot)
|
|||
|
||||
/**** Toggle operator for turning sculpt mode on or off ****/
|
||||
|
||||
/** \warning Expects a fully evaluated depsgraph. */
|
||||
static void sculpt_init_session(Depsgraph *depsgraph, Scene *scene, Object *ob)
|
||||
{
|
||||
/* Create persistent sculpt mode data. */
|
||||
|
@ -8197,6 +8198,7 @@ void ED_object_sculptmode_enter_ex(Main *bmain,
|
|||
|
||||
if (flush_recalc) {
|
||||
DEG_id_tag_update(&ob->id, ID_RECALC_GEOMETRY);
|
||||
BKE_scene_graph_evaluated_ensure(depsgraph, bmain);
|
||||
}
|
||||
|
||||
/* Create sculpt mode session data. */
|
||||
|
@ -8204,10 +8206,6 @@ void ED_object_sculptmode_enter_ex(Main *bmain,
|
|||
BKE_sculptsession_free(ob);
|
||||
}
|
||||
|
||||
/* Make sure derived final from original object does not reference possibly
|
||||
* freed memory. */
|
||||
BKE_object_free_derived_caches(ob);
|
||||
|
||||
/* Copy the current mesh visibility to the Face Sets. */
|
||||
BKE_sculpt_face_sets_ensure_from_base_mesh_visibility(me);
|
||||
|
||||
|
|
|
@ -1477,8 +1477,6 @@ static void sculpt_undosys_step_decode(
|
|||
{
|
||||
Scene *scene = CTX_data_scene(C);
|
||||
ViewLayer *view_layer = CTX_data_view_layer(C);
|
||||
/* Sculpt needs evaluated state. */
|
||||
BKE_scene_view_layer_graph_evaluated_ensure(bmain, scene, view_layer);
|
||||
Object *ob = OBACT(view_layer);
|
||||
if (ob && (ob->type == OB_MESH)) {
|
||||
if (ob->mode & OB_MODE_SCULPT) {
|
||||
|
@ -1486,6 +1484,12 @@ static void sculpt_undosys_step_decode(
|
|||
}
|
||||
else {
|
||||
ED_object_mode_generic_exit(bmain, depsgraph, scene, ob);
|
||||
|
||||
/* Sculpt needs evaluated state.
|
||||
* Note: needs to be done here, as #ED_object_mode_generic_exit will usually invalidate
|
||||
* (some) evaluated data. */
|
||||
BKE_scene_graph_evaluated_ensure(depsgraph, bmain);
|
||||
|
||||
Mesh *me = ob->data;
|
||||
/* Don't add sculpt topology undo steps when reading back undo state.
|
||||
* The undo steps must enter/exit for us. */
|
||||
|
|
Loading…
Reference in New Issue