blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

Select Similar: hide 'threshold' from UI when not used 

When the 'threshold' is not used in the type we are comparing, just hide
it. This was obvious for some types (e.g. Materials), but maybe not so
on others (e.g. Polygon Sides) and potentionally confusing.

Reported by @hitrpr in chat.

Differential Revision: https://developer.blender.org/D13760
This commit is contained in:
Philipp Oeser 2022-01-07 11:26:05 +01:00
parent 255727b752
commit 9dc9692b09
Notes: blender-bot 2023-02-14 00:44:02 +01:00 
Referenced by commit 812a9728f8, Select Similar: hide 'compare' from UI when not used
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
source/blender/editors/mesh/editmesh_select_similar.c
View File

@ -1334,6 +1334,33 @@ static const EnumPropertyItem *select_similar_type_itemf(bContext *C,
return prop_similar_types;
}
static bool edbm_select_similar_poll_property(const bContext *UNUSED(C),
wmOperator *op,
const PropertyRNA *prop)
{
const char *prop_id = RNA_property_identifier(prop);
const int type = RNA_enum_get(op->ptr, "type");
/* Only show threshold when it is used. */
if (STREQ(prop_id, "threshold")) {
if (!ELEM(type,
SIMVERT_NORMAL,
SIMEDGE_BEVEL,
SIMEDGE_CREASE,
SIMEDGE_DIR,
SIMEDGE_LENGTH,
SIMEDGE_FACE_ANGLE,
SIMFACE_AREA,
SIMFACE_PERIMETER,
SIMFACE_NORMAL,
SIMFACE_COPLANAR)) {
return false;
}
}
return true;
}
void MESH_OT_select_similar(wmOperatorType *ot)
{
PropertyRNA *prop;
@ -1347,6 +1374,7 @@ void MESH_OT_select_similar(wmOperatorType *ot)
ot->invoke = WM_menu_invoke;
ot->exec = edbm_select_similar_exec;
ot->poll = ED_operator_editmesh;
ot->poll_property = edbm_select_similar_poll_property;
/* flags */
ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;