Page MenuHome

Mask Overlay with Custom Color and Custom Spline Colors (per Mask Layer)
AbandonedPublic

Authored by Julian Eisel (Severin) on Apr 23 2015, 9:52 PM.

Details

Summary

Mask Overlay with Custom Color and Custom Spline Colors

Adds options to overlay the inner of masks with a custom color (rgba - using poly fill) and for changing the color of mask splines (both as a per layer option).

Feature request from @Sebastian Koenig (sebastian_k), actually I started working on this during the last BConf so was about time to finish and submit this ;P

Diff Detail

Event Timeline

Julian Eisel (Severin) retitled this revision from to Mask Overlay with Custom Color and Custom Spline Colors (per Mask Layer).
Julian Eisel (Severin) updated this object.
Julian Eisel (Severin) set the repository for this revision to rB Blender.

PS, Although these are two separate features I went with a single patch to avoid conflicts. Just before anybody complaints ;)

Thanks a lot for making a patch out of this! :)
I tested briefly and would propose a few changes:

  1. It seems a bit overkill to have different colors for spline and overlay. Wouldn't it be enough to have one color for both, and the alpha which applies only to the color overlay?

1a. Or actually, maybe just keep the current way of coloring when in outline mode, only when line display is changed to "line" (that other patch i believe?) use the mask color for the spline.

  1. Maybe it would be possible to change the blending? If I have several masklayers with the same color, I think it would be better to just merge them instead of alphaovering their values. Only if the colors are different, use alpha blending.
  2. Feathering should use the colors as well.

What do the others think? @Sean Kennedy (hype)?
:)

Thanks a lot for making a patch out of this! :)
I tested briefly and would propose a few changes:

  1. It seems a bit overkill to have different colors for spline and overlay. Wouldn't it be enough to have one color for both, and the alpha which applies only to the color overlay?

1a. Or actually, maybe just keep the current way of coloring when in outline mode, only when line display is changed to "line" (that other patch i believe?) use the mask color for the spline.

  1. Maybe it would be possible to change the blending? If I have several masklayers with the same color, I think it would be better to just merge them instead of alphaovering their values. Only if the colors are different, use alpha blending.
  2. Feathering should use the colors as well.

What do the others think? @Sean Kennedy (hype)?
:)

I haven't tested it, but based on your comments, my desired functionality would be to have the spline and overlay both be the same color, not different.

I also agree that it would be ideal for the merging to not be adding the values together (if I am understanding correctly from your comment). Where masks overlap, ideal behavior would be for it all to keep a consistent value in the overlay color.

Feathering should definitely use the colors as well. The feather spline should be the same color as the main spline, and the falloff should be the same color as the overlay.

Again, I haven't tested it, so I'm commenting completely based off what I think I understand from the images posted above and Seb's comment.

Awesome feature Glad to see it's coming!

I'm skeptical about feature which fill the mask in:

  • Starting with simple stuff like non-closed splines being filled in and missing filling when zoomed in
  • Continuing with more tricky stuff like
  • It doesn't obviously support feathering, which makes an idea of faster preview of final result just vanish. If final-ish preview is needed we need to improve Overlay option.
  • This feature overlays on top of Overlay, making final result wrong

Spline colors are probably useful but form the quick test it does not behave correct as well. For example, create two splines on different layers and toggle selection with A. Spline from inactive layer is highlighted with white instead of it's color (as if it's active spline).

More feedback later during code review session with cambo.

source/blender/makesdna/DNA_mask_types.h
143

would use char[4] for screen-color.

As discussed on IRC, we need a smarter way to expose and configure custom colors for things like this (see also custom wire colors). This would preferably be done using a global color template system accessible through the User Preferences.
Abandoning until this is done, we can then think about such functionality again.