Page MenuHome

BGE: Change KX_WolrdInfo mathutils vector to color
ClosedPublic

Authored by Thomas Szepe (hg1) on Jul 26 2015, 4:23 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Thomas Szepe (hg1) retitled this revision from to BGE: Change KX_WolrdInfo mathutils vector to color.Jul 26 2015, 4:23 PM
Thomas Szepe (hg1) updated this object.
Thomas Szepe (hg1) updated this revision to Diff 4750.
This revision is now accepted and ready to land.Jul 26 2015, 9:45 PM

it looks good to me. I not tested : i trust you.

Sybren A. Stüvel (sybren) requested changes to this revision.

Please include a sample blend file that demonstrates the new functionality, including setting a new color object (like world.backgroundColor = some_color) and showing whether setting a single component works (like world.backgroundColor.r = 0.34). This is needed for the release log anyway, makes it much easier for us to test, and serves as future documentation.

This revision now requires changes to proceed.Jul 27 2015, 3:58 PM

What do you mean with "release log"? Did you mean the "release note" http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.75?

As I know we only need a sample blend file for new features. But this is only a little API change.
Also I think for a missing test file you don't need make a patch stopping "request changes". A simple comment should be enough.

Anyway here is my test file.

Thomas Szepe (hg1) updated this revision to Diff 4754.
  • Add missing KX_WorldInfo.rst documentation changes.
Sybren A. Stüvel (sybren) accepted this revision.

What do you mean with "release log"? Did you mean the "release note" http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.75?

Yup, that.

As I know we only need a sample blend file for new features. But this is only a little API change.

True that. It was only partially because of the release notes that I asked for it. In my experience an example file helps a lot when testing changes, as it shows more about the ideas of the programmer when (s)he made the changes.

Thanks for the test file, it's really extensive :)

This revision is now accepted and ready to land.Jul 27 2015, 5:43 PM
This revision was automatically updated to reflect the committed changes.