Page MenuHome
Differential D1501

Grab, rotate, scale with basepoint
Needs ReviewPublic
Actions

Authored by Jaume Bellet (mauge) on Sep 3 2015, 6:36 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Julian Eisel (Severin)
Maniphest Tasks
T45734: Grab, rotate, scale with basepoint
Summary

coming from https://github.com/mauge123/mechanical-blender

The patch adds the cursor as Snap Element, and "Manual" on Snap Target, and also "manual" as pivot point.

When Snap Target or pivot point are set to Manual you must first set it. If both are activated, pivot point goes first.

The target can be set once the transform is running using "B" Key.
The pivot point can be set once the transform is running using "C" Key.

When selecting the snap target or pivot points, events are bypassed on modal, so you can move around the scene.
You can also more around the scene pressing using "N" Key.

When rotating using a manual snap target, you can rotate using the resulting axis between both points, pressing "W" key once the target is selected.

Also there is missing a reference value for resize, and selecting a 3 points to define a plane for mirroring.

Any suggestion are welcome.

some videos uploaded

https://vimeo.com/139064792
https://vimeo.com/137361362
https://vimeo.com/137948265

Diff Detail

Repository
rB Blender

Event Timeline

Jaume Bellet (mauge) retitled this revision from to Patch applying T45734.Sep 3 2015, 6:36 PM
Jaume Bellet (mauge) updated this object.
Jaume Bellet (mauge) set the repository for this revision to rB Blender.
Jaume Bellet (mauge) updated this revision to Diff 5006.
Jaume Bellet (mauge) retitled this revision from Patch applying T45734 to Grab, rotate, scale with basepoint.Sep 3 2015, 7:39 PM
Justas Ingelevičius (ingis) added a subscriber: Justas Ingelevičius (ingis).Sep 4 2015, 11:19 AM

Thanks Jaume, its's huge improvement! Minor issue at least for me is that snap on target works sometimes only when zooming in and out slightly or changing view direction slightly. But in general it's amassing :)

Justas Ingelevičius (ingis) added a comment.Sep 4 2015, 9:18 PM

Little thing. When in edit mode and manual snap target activated. This manual snap point could not be selected on active vertex itself. Workaround would be to switch modes, but for consistency I think it would be better to be able to select even active vertex itself.

Jaume Bellet (mauge) updated this object.Sep 12 2015, 4:20 PM
Jaume Bellet (mauge) updated this revision to Diff 5058.

This commit fixes some issues founds, and enhances UI input, like custom cursors to indicate you are selecting a point.

The "C" keystroke for directly select cursors as snap target has been removed, as is best using the snap_target as cursor.

The manual snap target select has diverged from snap code, and now it using a selected_point also used to select the pivot_point.

mathieu menuet (bliblubli) added a subscriber: mathieu menuet (bliblubli).EditedOct 19 2015, 10:20 PM

This patch doesn't work anymore. It's a really good addition, please update it :)

Jaume Bellet (mauge) updated this revision to Diff 5243.Oct 20 2015, 4:03 AM

It can now be applied to bf master and includes the transform multiple feature.

mathieu menuet (bliblubli) added a comment.Oct 20 2015, 8:03 PM

with your update and VS2013 i get this:

source\blender\editors\transform\transform_constraints.c(504) : error C2059: syntax error : '}'
source\blender\editors\transform\transform_constraints.c(508) : error C2065: 'v2' : undeclared identifier
source\blender\editors\transform\transform_constraints.c(508) : warning C4047: 'function' : 'float *' differs in levels of indirection from 'int'
source\blender\editors\transform\transform_constraints.c(508) : warning C4024: 'sub_v3_v3v3' : different types for formal and actual parameter 1
source\blender\editors\transform\transform_constraints.c(509) : error C2065: 'v2' : undeclared identifier
source\blender\editors\transform\transform_constraints.c(509) : warning C4047: 'function' : 'const float *' differs in levels of indirection from 'int'
source\blender\editors\transform\transform_constraints.c(509) : warning C4024: 'cross_v3_v3v3' : different types for formal and actual parameter 3

Master branch compiles without problem.
I use "arc patch D1501" and it applies without error but some warnings about whitespaces.

Jaume Bellet (mauge) updated this revision to Diff 5253.Oct 20 2015, 11:46 PM

Solves compiler error on empty vector initialization

mathieu menuet (bliblubli) added a comment.Oct 21 2015, 7:53 PM

Hi Jaume,
Thank you, it gets better, but VS still gives errors:
source\blender\editors\transform\transform_snap.c(966) : error C2059: syntax error : '}'

Jaume Bellet (mauge) updated this revision to Diff 5263.Oct 21 2015, 9:40 PM

Solved same issue of bad empty vector initialization. I'm not Windows user (was working fine for me) and i did not detect it in previous diff upload.

mathieu menuet (bliblubli) added a comment.Oct 22 2015, 9:36 PM

Really strange error this time. While compiling, it start makesrna.exe, which then crash and breaks the compile process, but without any usefull error message (just : "terminated because of errors"). I build with scons on vs2013 / win7 x64. Master still builds without problems so it doesn't come from the environment.

Jaume Bellet (mauge) added a comment.Oct 23 2015, 10:02 AM

Um.... as I am not a VS studio user (no windows avaliable at this moment), it's dificult for me to see what's going on, as in as is working (for me) on linux.

I've seen that for any unknown reason the struct draw_channels_items was lost the null termination, i'll re-upload the patch again..

Jaume Bellet (mauge) updated this revision to Diff 5268.Oct 23 2015, 10:04 AM

Null terminated for draw_channels_items struct was lost.

mathieu menuet (bliblubli) added a comment.Oct 23 2015, 8:51 PM

I get errors now applying the patch:

C:\Users\test\AppData\Local\Temp\d5uhf4fgwokw4ws\23415B3.tmp:530: trailing whitespace.
                Object *ob = base->object;
C:\Users\test\AppData\Local\Temp\d5uhf4fgwokw4ws\23415B3.tmp:1605: trailing whitespace.

Checking patch source/blender/windowmanager/intern/wm_event_system.c...
Checking patch source/blender/makesrna/intern/rna_space.c...
Checking patch source/blender/makesrna/intern/rna_scene.c...
Checking patch source/blender/makesrna/intern/rna_access.c...
Checking patch source/blender/makesrna/RNA_access.h...
Checking patch source/blender/makesdna/DNA_windowmanager_types.h...
Checking patch source/blender/makesdna/DNA_view3d_types.h...
Hunk #1 succeeded at 320 (offset -1 lines).
Checking patch source/blender/makesdna/DNA_scene_types.h...
Checking patch source/blender/editors/transform/transform_snap.c...
Checking patch source/blender/editors/transform/transform_ops.c...
Checking patch source/blender/editors/transform/transform_manipulator.c...
Checking patch source/blender/editors/transform/transform_generics.c...
C:\Users\test\AppData\Local\Temp\d5uhf4fgwokw4ws\23415B3.tmp:883: new blank line at EOF.
+
Checking patch source/blender/editors/transform/transform_conversions.c...
Checking patch source/blender/editors/transform/transform_constraints.c...
Checking patch source/blender/editors/transform/transform.h...
Checking patch source/blender/editors/transform/transform.c...
Checking patch source/blender/editors/include/ED_transform.h...
Applied patch source/blender/windowmanager/intern/wm_event_system.c cleanly.
Applied patch source/blender/makesrna/intern/rna_space.c cleanly.
Applied patch source/blender/makesrna/intern/rna_scene.c cleanly.
Applied patch source/blender/makesrna/intern/rna_access.c cleanly.
Applied patch source/blender/makesrna/RNA_access.h cleanly.
Applied patch source/blender/makesdna/DNA_windowmanager_types.h cleanly.
Applied patch source/blender/makesdna/DNA_view3d_types.h cleanly.
Applied patch source/blender/makesdna/DNA_scene_types.h cleanly.
Applied patch source/blender/editors/transform/transform_snap.c cleanly.
Applied patch source/blender/editors/transform/transform_ops.c cleanly.
Applied patch source/blender/editors/transform/transform_manipulator.c cleanly.
Applied patch source/blender/editors/transform/transform_generics.c cleanly.
Applied patch source/blender/editors/transform/transform_conversions.c cleanly.
Applied patch source/blender/editors/transform/transform_constraints.c cleanly.
Applied patch source/blender/editors/transform/transform.h cleanly.
Applied patch source/blender/editors/transform/transform.c cleanly.
Applied patch source/blender/editors/include/ED_transform.h cleanly.
warning: 3 lines add whitespace errors.
Jaume Bellet (mauge) added a comment.Oct 23 2015, 10:30 PM

I always check the patch before submitting... and I cannot see the error. I see you apply the patch over a more recent version of master, so i upgraded my base. I use patch command, so I tryed to apply the patch using arcanist and i get OKAY Successfully committed patch. Only a hunk offset, which is not a problem/error.

Did you tried to build it ¿?

mathieu menuet (bliblubli) added a comment.Oct 23 2015, 10:49 PM

And it works :) Nice job. Even better than I expected, we can move the view while grabbing!!!! Please make a separate patch for it to get it in trunk. For the purpose of the patch itself, nicely done. I miss some feedback sometime. The little circle around the vertex that will be chosen to snap is not showing every-time. Sometime yes, sometime not, but I couldn't find a reproducible way to showcase it.
By the way you did both well during the conference regarding the issues you had with the technique :)
Going to test further, but thumbs up on that one anyway :)

mathieu menuet (bliblubli) awarded a token.Oct 23 2015, 10:49 PM

Oh and by the way, add some reviewers like Campbell ?

mathieu menuet (bliblubli) added a comment.Oct 23 2015, 10:54 PM

Edit: We can only move the view while moving the snap target/element. It would be nice to make it consistent and add it to the grab/duplicate/rotate and scale function.

Jaume Bellet (mauge) added a comment.Oct 23 2015, 11:37 PM

I think we should move this kind of comments on the Task rather than the diff ;)

Yes, you can move around the scene to select the points, that was because i considered interesting to allow it for better selection ;) it's done bypassing events on the modal, this means it's not modal, so mouse inputs as not working as usual when applying the transform. I was thinking on a keystroke or button to enable/disable the modal.

We have had a presentation about this feature, but i have problems... because i upgraded my OS on July, and i did not test the video output from then (was working before), so it was not working due to drivers issues.. You can see it there

https://www.youtube.com/watch?v=pBDWdeaBueo

the first 15 minuts we are trying to solve the problem. it is a 30 min presentation. Also @Justas Ingelevičius (ingis) is presenting and addon related to cad improvements.

Jaume Bellet (mauge) updated this object.Oct 24 2015, 7:26 PM
Jaume Bellet (mauge) updated this revision to Diff 5273.

Add the kestroke N while performing a transform allowing user to move around the scene.

It also ads an icon to enable by default the transform-multiple flag

mathieu menuet (bliblubli) added a comment.Oct 24 2015, 7:46 PM

Nice :) But i get following error:

error: unpack requires a string argument of length 8:
  File "C:\Users\test\blender_git_v2\blender\SConstruct", line 825:
    data_to_c_simple_icon("release/datafiles/blender_icons16")
  File "C:\Users\test\blender_git_v2\blender\SConstruct", line 768:
    datatoc_icon.main_ex(argv)
  File "source/blender/datatoc\datatoc_icon.py", line 156:
    icondir_to_png(path_src, file_dst)
  File "source/blender/datatoc\datatoc_icon.py", line 135:
    icon_merge(f, pixels_canvas, canvas_w, canvas_h)
  File "source/blender/datatoc\datatoc_icon.py", line 88:
    head, pixels = icon_read(file_src)
  File "source/blender/datatoc\datatoc_icon.py", line 81:
    head, pixels = icon_decode(f_src)
  File "source/blender/datatoc\datatoc_icon.py", line 62:
    head = icon_decode_head(f_src)
  File "source/blender/datatoc\datatoc_icon.py", line 48:
    icon_w, icon_h = struct.unpack('<2I', temp_data)
Jaume Bellet (mauge) updated this revision to Diff 5279.Oct 25 2015, 1:44 PM

Icon stuff have been removed from diff as it seems there are some issues with it on previous diff.

Full test can be with a checkout from https://github.com/mauge123/mechanical-blender, enabling WITH_MECHANICAL flag.

mathieu menuet (bliblubli) added a comment.Oct 25 2015, 2:41 PM

compiles now much further, but again the makesrna.exe problem: While compiling, it start makesrna.exe, which then crash and breaks the compile process, but without any usefull error message (just : "terminated because of errors").

Jaume Bellet (mauge) updated this revision to Diff 5287.Oct 25 2015, 8:06 PM

Should fixes an issue on RNA on some systems, although i cannot check as it works for me.

@mathieu menuet (bliblubli) maybe you could try to checkout from https://github.com/mauge123/mechanical-blender

the branch mechanical-grab-w-basepint-bf should match this patch. the master may include more mechanical/architectural CAD improvements. we'll try to keep regularly updated with bf blender master.

mathieu menuet (bliblubli) added a comment.Oct 25 2015, 10:21 PM

Sweeeeeeeeeeettt :) Just tested this patch, it rocks. I'll check your branch tomorrow to see the other goodies !

mathieu menuet (bliblubli) added a comment.Oct 29 2015, 8:35 AM

Would it be possible to make the free view default behavior? At the moment, axis constrained can be done with (shift) x,y and z (and is done this way by all artists I know). So having the MMB also for it by default is redundant. People not using the keyboard shortcut, if any, can then press N to get the old behavior back. In the meantime it would also solve the keymap problem for most people.

mathieu menuet (bliblubli) added a comment.Nov 1 2015, 10:05 AM

by the way, specify a reviewer like Campbell.

Revision Contents
Changeset List

Diff 5287

View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/editors/include/ED_transform.h

Loading...
View Options

source/blender/editors/transform/transform.h

Loading...
View Options

source/blender/editors/transform/transform.c

Loading...
View Options

source/blender/editors/transform/transform_constraints.c

Loading...
View Options

source/blender/editors/transform/transform_conversions.c

Loading...
View Options

source/blender/editors/transform/transform_generics.c

Loading...
View Options

source/blender/editors/transform/transform_manipulator.c

Loading...
View Options

source/blender/editors/transform/transform_ops.c

Loading...
View Options

source/blender/editors/transform/transform_snap.c

Loading...
View Options

source/blender/makesdna/DNA_scene_types.h

Loading...
View Options

source/blender/makesdna/DNA_view3d_types.h

Loading...
View Options

source/blender/makesdna/DNA_windowmanager_types.h

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_access.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...
View Options

source/blender/windowmanager/intern/wm_event_system.c

Loading...