Page MenuHome

Select Tracks with Error Value Curve
Needs ReviewPublic

Authored by Marcelo Mutzbauer (1xundoredo) on Sep 6 2015, 1:52 PM.

Details

Summary

implements T41722 + 'view all' takes error curves into account

Diff Detail

Repository
rB Blender
Branch
_track_graph_err

Event Timeline

Marcelo Mutzbauer (1xundoredo) retitled this revision from to Select Tracks with Error Value Curve.
Marcelo Mutzbauer (1xundoredo) updated this object.
Marcelo Mutzbauer (1xundoredo) set the repository for this revision to rB Blender.
Marcelo Mutzbauer (1xundoredo) updated this object.
  • Pass -1 for coord of error value
Sergey Sharybin (sergey) requested changes to this revision.Sep 7 2015, 1:13 PM
Sergey Sharybin (sergey) edited edge metadata.

Generally seems nice patch, some cleanup and could be moved to Git after 2.76 release.

@Sebastian Koenig (sebastian_k), mind applying and testing?

source/blender/editors/space_clip/clip_graph_ops.c
127

Please don't re-arrange lines in unrealted areas.

179

(sc->flag & SC_SHOW_GRAPH_TRACKS_MOTION) != 0, also return is on the next line.

239

It's more readable to get flags outside of the call.

314

Name doesn't follow naming convention of the poll functions.

source/blender/editors/space_clip/clip_intern.h
124

Make it anonymous enum, also suggested name is CLIP_ITER_TRACK_{SPEED, ERROR}.

This revision now requires changes to proceed.Sep 7 2015, 1:13 PM
Marcelo Mutzbauer (1xundoredo) edited edge metadata.

I hope I got the naming convention for the poll function right.

Marcelo Mutzbauer (1xundoredo) marked 3 inline comments as done.Sep 7 2015, 2:03 PM
Marcelo Mutzbauer (1xundoredo) edited edge metadata.
  • Fix knots not being selectable(if statement actually had to be (sc->flag & SC_SHOW_GRAPH_TRACKS_MOTION) == 0)
  • Rename poll function to 'select_poll'