Cycles: Support user-defined shutter curve
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Oct 27 2015, 3:27 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Martijn Berger (juicyfruit)

Group Reviewers

Cycles

Commits

rBSb909dfdae140: Cycles: Expose user-defined shutter curve to the interface
rC082ed0bff9f7: Expose user-defined shutter curve to the interface
rBb909dfdae140: Cycles: Expose user-defined shutter curve to the interface

Summary

Previously shutter was instantly opening, staying opened for the shutter time
period of time and then instantly closing. This isn't quite how real cameras
are working, where shutter is opening with some curve. Now it is possible to
define user curve for how much shutter is opened across the sampling period
of time.

This could be used for example to make motion blur trails softer.

Shutter curve now can be controlled using curve mapping widget in the motion
blur panel in Render buttons. Only mapping from 0..1 by x axis are allowed,
Y values will be normalized to fill in 0..1 space as well automatically.

Y values of 0 means fully closed shutter, Y values of 1 means fully opened
shutter.

Default mapping is set to old behavior when shutter opens and closes instantly.

This shutter mapping curve could easily be used by any other render engine by
accessing scene.render.motion_blur_shutter_curve.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) retitled this revision from to Cycles: Support user-defined shutter curve.Oct 27 2015, 3:27 PM

Sergey Sharybin (sergey) added reviewers: Cycles, Brecht Van Lommel (brecht), Martijn Berger (juicyfruit), Campbell Barton (campbellbarton).

Sergey Sharybin (sergey) updated this object.

Sergey Sharybin (sergey) updated this revision to Diff 5311.

Generally fine, some minor points.

source/blender/blenkernel/BKE_colortools.h
57	Would call `CURVEMAP_SLOPE_POS_NEG` since we're already using those terms here.
source/blender/makesrna/intern/rna_scene.c
5373	Typo, also could be changed to: "Curve defining the shutters openness over time" Though no string opinion here.

This revision is now accepted and ready to land.Oct 27 2015, 3:44 PM

@Campbell Barton (campbellbarton), thanks for the review.

Here're some images of the results;

Rendering with default shutter time and curve:

Rendering with triangle shaped shutter curve:

Rendering with default shutter curve but lower shutter time (for trails comparison):

On OS X I'm seeing random crashes, not single backtrace, but it's always crashing in memory freeing something. For example: start with factory settings, switch to cycles, enable motion blur and expand panel to show curves, F12 render.

Valgrind can probably find the cause.

intern/cycles/render/camera.cpp
42 ↗	(On Diff #5311)	This should be `return shutter_curve[RAMP_TABLE_SIZE - 1]`.

Updates with feedback from Campbell and fixes for Brecht

@Brecht Van Lommel (brecht), think i've nailed all bad memory access now, mind checking it again?

Looks good to me now, no crashes anymore.

Both looks good and works for me.

Closed by commit rBb909dfdae140: Cycles: Expose user-defined shutter curve to the interface (authored by Sergey Sharybin (sergey)). · Explain WhyOct 27 2015, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			intern/cycles/blender/addon/ui.py (13 lines)
M			intern/cycles/blender/blender_camera.cpp (9 lines)
M			intern/cycles/blender/blender_util.h (10 lines)
M			source/blender/blenkernel/BKE_colortools.h (2 lines)
M			source/blender/blenkernel/intern/colortools.c (2 lines)
M			source/blender/blenkernel/intern/scene.c (3 lines)
M			source/blender/blenloader/intern/readfile.c (2 lines)
M			source/blender/blenloader/intern/versioning_270.c (16 lines)
M			source/blender/blenloader/intern/writefile.c (1 line)
M			source/blender/editors/render/render_intern.h (1 line)
M			source/blender/editors/render/render_internal.c (42 lines)
M			source/blender/editors/render/render_ops.c (1 line)
M			source/blender/makesdna/DNA_scene_types.h (3 lines)
M			source/blender/makesrna/intern/rna_scene.c (5 lines)
M			source/blender/render/intern/source/pipeline.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5311	505a31b		Oct 27 2015, 3:27 PM	★	★
Diff 2	5314	242246e	Updates with feedback from Campbell and fixes for Brecht	Oct 27 2015, 6:28 PM	★	★
Diff 3	5316	6a529e1	Commit rBb909dfdae140ba0cc71003ad30dc612b059732d6	Oct 27 2015, 10:43 PM	★	★

Cycles: Support user-defined shutter curveClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5316

intern/cycles/blender/addon/ui.py

intern/cycles/blender/blender_camera.cpp

intern/cycles/blender/blender_util.h

source/blender/blenkernel/BKE_colortools.h

source/blender/blenkernel/intern/colortools.c

source/blender/blenkernel/intern/scene.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/versioning_270.c

source/blender/blenloader/intern/writefile.c

source/blender/editors/render/render_intern.h

source/blender/editors/render/render_internal.c

source/blender/editors/render/render_ops.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesrna/intern/rna_scene.c

source/blender/render/intern/source/pipeline.c

Cycles: Support user-defined shutter curve
ClosedPublic
Actions

Revision Contents
Changeset List