Page MenuHome

TRANSFORM: center2d Duplicity removed.
Needs ReviewPublic

Authored by Jaume Bellet (mauge) on Oct 28 2015, 1:47 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Removed duplicity between t->mouse.center and t->center2d. Using always t->center2d

Diff Detail

Repository
rB Blender

Event Timeline

Jaume Bellet (mauge) retitled this revision from to TRANSFORM: center2d Duplicity removed..Oct 28 2015, 1:47 PM
Jaume Bellet (mauge) updated this object.
Jaume Bellet (mauge) set the repository for this revision to rB Blender.
Jaume Bellet (mauge) updated this revision to Diff 5323.

The diff assumes saving center2d on transform, instead of saving it under transform/mouse/center. I did in this way becuse the center is more related to transform than mouse input, but maybe is better to save 2D data under mouse

Of course duplicating variables about isn't great, since it can cause confusion or problems if their values diverge,
but the tradeoff is t->mouse is no longer self contained struct we can use on its own.

If we have to pass TransInfo into functions it means the mouse-input functions, they can access everything, scene/object.... etc.

So in this case I rather just have both t->center2d and mouse.center and leave this part of the code as-is.

Jaume Bellet (mauge) updated this revision to Diff 5332.

Then maybe this is a better aproach