Page MenuHome

BGE: Remove BL_ShapeActionActuator
AbandonedPublic

Authored by Porteries Tristan (panzergame) on Nov 1 2015, 1:40 PM.

Details

Summary

BL_ShapeActionActuator is not used since 2.50 and converted to a normal action actuator.

BL_ShapeActionActuator is removed in BGE, the editor draw function, and the python doc too.
in BL_ActionActuator some flag can be removed.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D1601

Event Timeline

Porteries Tristan (panzergame) retitled this revision from to BGE: Remove BL_ShapeActionActuator BL_ShapeActionActuator is not used since 2.50 and converted to a normal action actuator..
Porteries Tristan (panzergame) updated this object.
Porteries Tristan (panzergame) retitled this revision from BGE: Remove BL_ShapeActionActuator BL_ShapeActionActuator is not used since 2.50 and converted to a normal action actuator. to BGE: Remove BL_ShapeActionActuator.Nov 1 2015, 1:41 PM
Porteries Tristan (panzergame) updated this object.
  • Remove ACT_SHAPEACTION in sca.c and write.c
Campbell Barton (campbellbarton) added inline comments.
source/gameengine/Converter/BL_ActionActuator.h
144–150

These values are changed, wont they be saved to disk as their previous values?

source/gameengine/Converter/BL_ActionActuator.h
144–150

These values are set internally in the actuator during process. You can see in constructor : m_flag(0) and in Update line 190, the switch statement :

	// Convert our playtype to one that BL_Action likes
	switch (m_playtype) {
		case ACT_ACTION_LOOP_END:
                    playtype = BL_Action::ACT_MODE_LOOP;
        …
This revision is now accepted and ready to land.Nov 3 2015, 7:08 PM

As long as you've tested converting an old blend file with a shape action actuator, then this looks good to me.

As long as you've tested converting an old blend file with a shape action actuator, then this looks good to me.

That's why I haven't accepted this diff yet. I asked for such a test file on multiple occasions, but haven't seen one yet. I doubt that such testing was performed.

@Sybren A. Stüvel (sybren):

I don't know why it's impossible to set the action name in 2.49, if you succeed please send the .blend, other than that the actuator logic brick is properly converted in latest blender version.

The action doesn't seem to do anything. I can create an animation using Key 1, but that's not the point of a test example -- that should work out of the box. I tested on 2.77-testbuild2.

Closing this revision as the BGE is no more.