Page MenuHome

T37875 - some additional options
ClosedPublic

Authored by Michał Ziobro (Muchomor) on Jan 28 2016, 12:51 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Michał Ziobro (Muchomor) retitled this revision from to T37875 - some additional options.
Michał Ziobro (Muchomor) updated this object.
Michał Ziobro (Muchomor) set the repository for this revision to rB Blender.
Brecht Van Lommel (brecht) requested changes to this revision.Jan 30 2016, 2:01 PM
Brecht Van Lommel (brecht) edited edge metadata.

Thanks! I only have some minor nitpicks, the functionality seems to work fine.

@Campbell Barton (campbellbarton), I think you added this to the quick hacks list initially, maybe you have some comments.

source/blender/editors/armature/armature_select.c
864

This function should be static.

865

Style: put return; on a new line, and without the space between.

884

Style, use space: EBONE_SELECTABLE(arm, ebone_iter)

893

Same style note as above.

903

Same style note as above.

906

Same style note as above.

This revision now requires changes to proceed.Jan 30 2016, 2:01 PM
Michał Ziobro (Muchomor) edited edge metadata.

Hmm, I think it's fixed.

Brecht Van Lommel (brecht) edited edge metadata.

Looks good, I'll commit this soon if there are no further comments from others.

This revision is now accepted and ready to land.Jan 30 2016, 3:18 PM
This revision was automatically updated to reflect the committed changes.