Page MenuHome

T37875 - some additional options

Authored by Michał Ziobro (Muchomor) on Jan 28 2016, 12:51 PM.

Diff Detail

rB Blender

Event Timeline

Michał Ziobro (Muchomor) retitled this revision from to T37875 - some additional options.
Michał Ziobro (Muchomor) updated this object.
Michał Ziobro (Muchomor) set the repository for this revision to rB Blender.
Brecht Van Lommel (brecht) requested changes to this revision.Jan 30 2016, 2:01 PM
Brecht Van Lommel (brecht) edited edge metadata.

Thanks! I only have some minor nitpicks, the functionality seems to work fine.

@Campbell Barton (campbellbarton), I think you added this to the quick hacks list initially, maybe you have some comments.


This function should be static.


Style: put return; on a new line, and without the space between.


Style, use space: EBONE_SELECTABLE(arm, ebone_iter)


Same style note as above.


Same style note as above.


Same style note as above.

This revision now requires changes to proceed.Jan 30 2016, 2:01 PM
Michał Ziobro (Muchomor) edited edge metadata.

Hmm, I think it's fixed.

Brecht Van Lommel (brecht) edited edge metadata.

Looks good, I'll commit this soon if there are no further comments from others.

This revision is now accepted and ready to land.Jan 30 2016, 3:18 PM
This revision was automatically updated to reflect the committed changes.