Show categories in search-box
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Feb 3 2016, 11:36 AM.

Details

Reviewers

Bastien Montagne (mont29)
Julian Eisel (Severin)
Pablo Vazquez (pablovazquez)

Summary

This diff shows the categories for each operator in the operator search popup.

This helps by giving some context to the operators which are often named assuming they will be access from a menu where the context is already quite obvious.

Example of a similar tool search popup for the atom editor.

One problem with this patch is the categories for operators is currently an 'internal' field that users never see, so its not always so user-friendly
(wm instead of WindowManager, ED instead of Editor for example).

We could always have a lookup table stored that shows a more friendly name, but this would ideally need to be extended so addons could include their own prefix, which gets a bit messy.

Diff Detail

Repository: rB Blender
Branch: arcpatch-D1760

Event Timeline

Campbell Barton (campbellbarton) updated this revision to Diff 5949.Feb 3 2016, 11:36 AM

Campbell Barton (campbellbarton) retitled this revision from to Show categories in search-box.

Campbell Barton (campbellbarton) updated this object.

Campbell Barton (campbellbarton) added reviewers: Pablo Vazquez (pablovazquez), Bastien Montagne (mont29), Julian Eisel (Severin).

Campbell Barton (campbellbarton) updated this object.Feb 3 2016, 11:47 AM

Campbell Barton (campbellbarton) added a project: User Interface.

Big +1 for me, this is much much better than current op search box - and I think that minor glitches like Wm or Ed are not a reason to stop it. ;)

We can also rename those categories to better names, noisy change for sure but not that hard I think (except maybe some issues with addons?).

Also, when name is only two or three letters, you could keep it all capitalized (UI, ED, WM, UV…)?

This revision is now accepted and ready to land.Feb 3 2016, 1:26 PM

Campbell Barton (campbellbarton) updated this object.Feb 4 2016, 3:32 AM

Campbell Barton (campbellbarton) edited edge metadata.

Campbell Barton (campbellbarton) updated this object.

+1 This looks good.

Capitalizing small names sounds good too. I don't think addons will be much of a problem. Most of them use the addon name as the op category. There could be a small tip in the "best practices" in the API docs to push devs into writing descriptive categories.

Users can infer that names on the left side are categories (because they repeat), so it's not necessary to repeat the ":".

Also, it could be useful to differentiate the hotkeys with a different color. Like the engine name in the "render engine" tooltip for instance.

Paweł Łyczkowski (plyczkowski) awarded a token.Feb 5 2016, 1:26 AM

Big +1 for the feature itself.

I guess code is not finished yet? Has some weird looking things in it, like unused uiSearchboxData variable, ELEM check for single element, etc ;) A major issue is that it's currently just always calling ui_searchbox_region_draw_cb__operator instead of ui_searchbox_region_draw_cb, causing crashes for all non-OP search menus. Only solution I see would be adding something like UI_BLOCK_SEARCH_MENU_OT flag or UI_BTYPE_SEARCH_MENU_OT button type :/
Would also pack code for getting category from OP name into own util function, guess you'd do that anyway though.

EDIT: Maybe adding UI_BTYPE_SEARCH_MENU_OT wouldn't be that bad. If we at some point (hopefully soon) change to an inheritance based uiBut struct such variations can be turned into flags for a specific button type, so we shouldn't worry that much about it.

This revision now requires changes to proceed.Feb 11 2016, 1:41 AM

Julian Eisel (Severin) awarded a token.Feb 11 2016, 1:43 AM

Another minor annoyance is that for abbreviations, only the first letter is written in capitals... (Wm, Ui, Ed) Not a big issue, but keeps bugging me :S If we add a util function for getting category out of name, maybe an ugly hardcoded string comparison would be okay to avoid that? Or maybe a if (strlen(str) < 3) check or similar.

Resolve mistake where all search buttons were assumed to be for operators

Don't change the size of _all_ search popups, instead just make operator searches larger.

@Julian Eisel (Severin), thanks for checking - and excuse the errors, would normally take more care, this was an experimental change I had stashed from months ago and decided to upload it for initial review (to see if we even want to have this functionality).

Went over the patch in more detail fixing 2 issues, and think its stable/ready for master now.

Wm Ui and Ed also bug me :S. tsk!

finish comment

Campbell Barton (campbellbarton) added inline comments.Feb 15 2016, 1:10 PM

source/blender/editors/interface/interface_widgets.c
4090–4093	This should be committed separate, I was getting an assert here IIRC.

I've not tested this yet but also major +1 from me for usability improvement.

Should be fine to commit now? :)

Committed

rB69b66d549bcc82b5667916e647d43578bada5dd2 callback changes.
rBd49985ce488f7d734ae727379e5bb4569a9dc700 search popup changes.

Campbell Barton (campbellbarton) abandoned this revision.Mar 2 2016, 4:18 AM

Revision Contents
Changeset List

			Path	Packages
M			source/blender/editors/include/UI_interface.h (5 lines)
M			source/blender/editors/interface/interface.c (16 lines)
M			source/blender/editors/interface/interface_handlers.c (2 lines)
M			source/blender/editors/interface/interface_intern.h (4 lines)
M			source/blender/editors/interface/interface_layout.c (2 lines)
M			source/blender/editors/interface/interface_regions.c (103 lines)
M			source/blender/editors/interface/interface_templates.c (12 lines)
M			source/blender/editors/interface/interface_widgets.c (4 lines)
M			source/blender/editors/space_node/node_select.c (2 lines)
M			source/blender/editors/space_view3d/view3d_toolbar.c (2 lines)
M			source/blender/windowmanager/intern/wm_operators.c (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5949	2a65acc		Feb 3 2016, 11:36 AM	★	★
Diff 2	6086	318d3b9	- Resolve mistake where all search buttons were assumed to be for operators	Feb 15 2016, 12:15 PM	★	★
Diff 3	6087	318d3b9	- Don't change the size of _all_ search popups, instead just make operator searches larger.	Feb 15 2016, 12:40 PM	★	★
Diff 4	6088	318d3b9	- finish comment	Feb 15 2016, 12:51 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8a1dc0ac3d79	0365a0c0040f	84e485c2fd5c	Campbell Barton	finish comment	Feb 15 2016, 12:42 PM
84e485c2fd5c	6b35afd668ed	ac0c47bd6e2c	Campbell Barton	Don't change the size of _all_ search popups, instead just make operator… (Show More…)	Feb 15 2016, 12:31 PM
ac0c47bd6e2c	2e09d131b77a	86b123a58afd	Campbell Barton	Resolve mistake where all search buttons were assumed to be for operators	Feb 15 2016, 12:06 PM
86b123a58afd	ad7b66e812e1	318d3b9ab40b	Campbell Barton	Show categories in search-box (Show More…)	Feb 15 2016, 11:12 AM