Page MenuHome

CMake ranlib error on mac fix
ClosedPublic

Authored by Tianwei Shen (hlzz001) on Apr 23 2016, 10:23 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Tianwei Shen (hlzz001) retitled this revision from to CMake ranlib error on mac fix.
Tianwei Shen (hlzz001) updated this object.
Tianwei Shen (hlzz001) set the repository for this revision to rB Blender.
Campbell Barton (campbellbarton) requested changes to this revision.Apr 23 2016, 11:15 AM
Campbell Barton (campbellbarton) edited edge metadata.

Is this only with GCC? or does it effect Clang too? (http://stackoverflow.com/questions/4929255 references GCC specifically).

If this is the case, it should check the compiler is GCC: if(CMAKE_C_COMPILER_ID MATCHES "GNU")

This revision now requires changes to proceed.Apr 23 2016, 11:15 AM

Clang shows the same warnings. I've seen these warnings on Mac since forever, nice to finally have a fix for them.

I'll go ahead and commit this, with tweaked comment and the code moved to the Apple specific section.

This revision was automatically updated to reflect the committed changes.