Page MenuHome

Fix input for Texture node (envmap+world_space_shading)
ClosedPublic

Authored by Alexander Romanov (a.romanov) on Jun 27 2016, 5:26 PM.

Details

Summary

This patch fixes shortcoming of D2046.
The original behavior without world_space_shading flag is that Texture node expects the reflected vector in view space. But with world_space_shading it should be in world space.

In attached file you will see a simple material setup and a node material analogue.

Simple material must have the same behavior regardless world_space_shading flag.

Alexander (Blend4Web Team)

Diff Detail

Repository
rB Blender

Event Timeline

Alexander Romanov (a.romanov) retitled this revision from to Fix input for Texture node (envmap+world_space_shading) .Jun 27 2016, 5:26 PM
Alexander Romanov (a.romanov) updated this object.
Alexander Romanov (a.romanov) updated this revision to Diff 6967.
Campbell Barton (campbellbarton) added inline comments.
source/blender/render/intern/source/envmap.c
749

*picky*, Blender code uses space after if/switch/for... etc. Another case below.

This revision is now accepted and ready to land.Jul 2 2016, 8:50 PM
This revision was automatically updated to reflect the committed changes.