Page MenuHome

BI Viewport(GLSL): support for envmap in Texture node
ClosedPublic

Authored by Alexander Romanov (a.romanov) on Jun 28 2016, 1:49 PM.

Details

Summary

This patch is another step to achieve BI and it's Viewport consistency for cubemap textures.

To test world_space_shading flag D2072 is required.

Alexander (Blend4Web Team)

Diff Detail

Repository
rB Blender

Event Timeline

Alexander Romanov (a.romanov) retitled this revision from to BI Viewport(GLSL): support for envmap in Texture node.Jun 28 2016, 1:49 PM
Alexander Romanov (a.romanov) updated this object.
Alexander Romanov (a.romanov) updated this revision to Diff 6973.
Brecht Van Lommel (brecht) requested changes to this revision.

Seems generally fine, if you fix these two things you can commit it I think.

source/blender/nodes/shader/nodes/node_shader_texture.c
127

Code style is if () {.

135–136

This should be done before direction_transform_m4v3?

This revision now requires changes to proceed.Jul 2 2016, 8:49 PM
Alexander Romanov (a.romanov) updated this revision to Diff 6998.
  • final corrections
Alexander Romanov (a.romanov) marked 2 inline comments as done.Jul 4 2016, 10:16 AM

Seems generally fine, if you fix these two things you can commit it I think.

All things are fixed. I will commit the patch.

This revision was automatically updated to reflect the committed changes.