T49347 part one
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Sep 15 2016, 3:11 PM.

Details

Summary

colors for vertex/edge bevels are now themeable

drawing used colors for select (TH_EDGE_SELECT/TH_VERTEX_SELECT) which was inconsistent with crease, seam,sharp, .. (which all had their own them color -- also was a bit hard to read)

note: part two will make this more consistent and also draw bevel edge colors in SCE_SELECT_VERTEX mode

Diff Detail

Repository
rB Blender

Hrmpf, we should absolutely not add any more theme options, UI team has decided to avoid this if possible. Not sure how to avoid it though... What do the other UI team guys say?

Julian Eisel (Severin) requested changes to this revision.Sep 16 2016, 3:45 PM

Requesting changes so nobody commits this until UI team gave input.

This revision now requires changes to proceed.Sep 16 2016, 3:45 PM

Though adding new theme options should be avoided (unless consolidating existing options), I consider this more of a fix of the current system, so +1 from me.

I'm conflicted on this. This is more of a fix for a previously missing component, like @Paweł Łyczkowski (plyczkowski) said, but at the same time there are many, many missing theme items like this. If we approve every one of them on the basis of it being a "fix" then we still have the problem of excessive theme items.

Hi UI-Team!

though I can try to think of / image reasons for not adding more theme options ('no-options-mantra'), could you elaborate on where this gets problematic?
Is there a guideline to follow?
Does it have to do with theme maintainance? (building a good theme would take even longer...)

It's somewhat clear why not to add a theme color for e.g. an manipulator-axis, but in this case it seems to be an improvement, no?
Especially because it also solves an incosistency with other vertex/edge data.

I would suggest to just add just one color (instead of two) and use this for vertices AND edges (but even that feels a little inconsistent with other mesh theme options -- and wouldnt really change the case here, I guess...)

Happy to get feedback and thanx for watching :)

btw. while we are at it [and this is also UI-related]: what are your opinions on D2236: T49347 part two?

though I can try to think of / image reasons for not adding more theme options ('no-options-mantra'), could you elaborate on where this gets problematic?
Is there a guideline to follow?
Does it have to do with theme maintainance? (building a good theme would take even longer...)

Reason is mostly because of theme maintenance. A while back I went through the theme settings to get some numbers, the results were quite jaw-dropping. We've run into a major usability issue by over-optioning things.

That being said, I'm afraid we've by far surpassed the point where we can improve anything or prevent something from getting too bad without major reworking. So TBH I don't think we should bother with this any longer and just fix this inconsistency by appling this patch.

@Julian Eisel (Severin) wrote:> That being said, I'm afraid we've by far surpassed the point where we can improve anything or prevent something from getting too bad without major reworking. So TBH I don't think we should bother with this any longer and just fix this inconsistency by apply this patch.

I'm inclined to agree.

Totally agree about the duplicated standard colors that you tweeted about, as well as some others.
Anyways, could someone mark this as 'Accepted' then? Or just commit? Thanx in advance

This revision was automatically updated to reflect the committed changes.