Page MenuHome

Small speedup for blend_render_info.py
ClosedPublic

Authored by Dmitry Dygalo (Stranger6667) on Sep 15 2016, 8:49 PM.

Details

Summary

It gives about 10-15% speedup on my machine for gzipped blend files

Diff Detail

Repository
rB Blender

Event Timeline

Dmitry Dygalo (Stranger6667) retitled this revision from to Small speedup for blend_render_info.py.
Dmitry Dygalo (Stranger6667) updated this object.
Dmitry Dygalo (Stranger6667) set the repository for this revision to rB Blender.

Humpf… yes, this will work nicely with modern python, but… according to the doc, gzip.open only accepts file objects as parameter since py3.3, would not be an issue if this script was to be run with Blender, but its purpose is precisely to be run outside of it…

So not sure about that, 3.3 is four years old, can we assume it's old enough to be minimum requirement here? @Sergey Sharybin (sergey), @Brecht Van Lommel (brecht), @Sybren A. Stüvel (sybren), @Julian Eisel (Severin), any strong opinion?

mont29, I thought, that this script should be compatible only with Python, which comes with current Blender version.

According to PEP398, Python 3.3 will reach EOL in September 2017

Whoops, it means that it will work on Python 3.3, so, Python 3.2 is unsupported right now

@Bastien Montagne (mont29), don't think this script is really used outside of a blender infrastructure anyway? Also, current debian stable has python3 version 3.4, so even there it's not a problem. Could be an issue on some CentOS but there one will have other issues making blender to run currently anyway.

Bastien Montagne (mont29) edited edge metadata.

Ok makes sense, will commit then, thanks for the patch.

This revision is now accepted and ready to land.Sep 20 2016, 12:31 PM
This revision was automatically updated to reflect the committed changes.