Page MenuHome

Change CMake rules when building Cycles (standalone) in debug mode
AbandonedPublic

Authored by Bojian Wu (boj) on Nov 18 2016, 5:10 PM.

Details

Summary

Actually, I try to build Cycles (standalone) on Windows 10 with Microsoft Visual Studio 2013, but in debug mode, it fails to link OpenImageIO and OpenEXR related libraries (mixed utilization of libraries of debug/release mode), so I make a minor change of CMake rules.

Diff Detail

Event Timeline

Bojian Wu (boj) retitled this revision from to Change CMake rules when building Cycles (standalone) in debug mode.Nov 18 2016, 5:10 PM
Bojian Wu (boj) updated this object.
Bojian Wu (boj) set the repository for this revision to rC Cycles.
Bojian Wu (boj) added a project: Cycles.
Bojian Wu (boj) updated this revision to Diff 7847.

Looks good to me except from some minor style things which are subjective

src/cmake/Modules/FindOpenEXR.cmake
125

I think it would look nicer with some new lines to break this up

151–154

same as above

Bojian Wu (boj) updated this revision to Diff 7856.

Thanks @Martijn Berger (juicyfruit), I have made some changes about my patch with your opinions, please review.

This should work fine now with latest master.