Page MenuHome

Fix T50888: Numeric overflow in split kernel state buffer size calculation
ClosedPublic

Authored by Mai Lavelle (maiself) on Mar 11 2017, 11:43 AM.

Details

Summary

Overflow led to the state buffer being too small and the split kernel to get stuck doing nothing forever.

Diff Detail

Event Timeline

This is a bit confusing to mix size_t and int64_t. Is that to ensure 64 bit address space on 32bit platforms?

This is a bit confusing to mix size_t and int64_t. Is that to ensure 64 bit address space on 32bit platforms?

Yes and also to deal with passing data to and from OpenCL kernels, as you cant pass size_t there.

Sergey Sharybin (sergey) edited edge metadata.

Ok, i see. Don't have much to comment about then. If it compiles/works just go ahead then.

This revision is now accepted and ready to land.Mar 11 2017, 12:10 PM