Page MenuHome

Fix T51215: Depsgraph evaluation of collection properties (overrides)
ClosedPublic

Authored by Dalai Felinto (dfelinto) on Apr 19 2017, 7:13 PM.

Details

Summary

IDP_MergeGroup doesn't work recursively. I'm open to suggestions, but for now I did a new function that is a mix of IDP_MergeGroup and IDP_SyncGroupValues.

Diff Detail

Repository
rB Blender
Branch
temp-idprop-merge-recursive
Build Status
Buildable 576
Build 576: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 20 2017, 10:20 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/blenkernel/intern/idprop.c
605

Would name IDP_MergeGroupRecursive (otherwise its not real obvious what the difference is to IDP_MergeGroup)

Update, reading how term ***Values is used here I suppose its OK.

just a bit confusing since IDP_MergeGroupValues makes it look like IDP_MergeGroup doesn't operate on values.

All things considered LGTM as is.