Page MenuHome

GSoC 2016 - Intersect tool
Needs ReviewPublic

Authored by João Araújo (genio84) on Jul 26 2017, 1:36 PM.

Details

Summary

For GSoC 2016 I added some new tools to work with Bezier Curves. However, since the final patch was too big for review, I was advised to submit the new tools as individual patches.

This commit implements the "Intersect" tool, aka old "Extend" tool. The reason the name was changed was to rename the "Batch Extend" tool to "Extend".

To avoid too much confusion, I will only submit the next tool's diff after this one has been accepted.

I took the liberty of adding all subscribers of the original final GSoC patch submission. Feel free to unsubscribe if you are uninterested in this topic.

Every piece of feedback is welcome!

Proposal:
https://wiki.blender.org/index.php/User:Genio84/gsoc2016/proposal

Reports:
https://wiki.blender.org/index.php/User:Genio84/gsoc2016/reports

End User Documentation:
https://wiki.blender.org/index.php/User:Genio84/gsoc2016/final_report/

Working Branch Used for Development:
https://developer.blender.org/diffusion/B/browse/gsoc2016-improved_extrusion/

Diff Detail

Event Timeline

Cool, lets get this into 2.8! :)

Very helpful for review. It's a pleasure to see a student with so long commitment.

Very helpful for review. It's a pleasure to see a student with so long commitment.

Lets indulge him and review this, a lot of people are very eager to get this into Blender :)

Hi, I've left some opening comments for review on style and naming. I'll need to spend some more time with the logic for this.

Also, I am receiving assertion failures when executing the OT, this should be fixed: BLI_assert failed: /home/kevin/blender-git/blender/source/blender/blenkernel/intern/curve.c:747, BKE_nurb_bezt_get_prev(), at 'nu->pntsv == 1'

source/blender/editors/curve/editcurve.c
6337

There should be a space between for and (

6338

Opening { should be on the same line as for - this style should be used for all iteration and conditional statements. See https://wiki.blender.org/index.php/Dev:Doc/Code_Style#Braces

6586

Functions should be called after variable declarations.

6667

Same line as opening statement for {

6670

Same line as opening statement for {

6782

I don't think it makes sense to use the old name here - should probably replace all instances of extend with intersect