Page MenuHome

Tracking: Highlight keyframes in path visualization
ClosedPublic

Authored by Sergey Sharybin (sergey) on Aug 4 2017, 11:11 PM.

Details

Summary

This gives better idea of what's going on with your track. Example:

Color of keyframes are configurable from theme editor of clip editor.

Diff Detail

Repository
rB Blender

Event Timeline

Update against latest master

This is great! Happy to test it if a Windows build is available!

This one looks really useful, also works great. :)

Hoping this is in the latest trunk, and makes it to 2.8. I haven't forgotten about these awesome motion tracking updates!

As mentioned before it's a very useful feature, also works great after a bit of testing. So I guess from artist's side it can be committed! :)

Can we please get this added in for 2.81?

Updated against latest master.

Julian Eisel (Severin) requested changes to this revision.EditedSep 16 2019, 9:38 PM

The theme changes should be fine. Noticed one drawing issue though.

Also, as this adds more glPointSize() calls, does that still work on macOS? @Clément Foucault (fclem)? AFAIK glLineWidth() doesn't.
If it doesn't we can just use GPU_SHADER_2D_POINT_FIXED_SIZE_UNIFORM_COLOR.

source/blender/editors/space_clip/clip_draw.c
481

Just like with T69960, num_points may be 0 or -1 here.

This revision now requires changes to proceed.Sep 16 2019, 9:38 PM

Rebased against latest master.

Solved asserts and crashes with 0 length paths.

As for the point size and line width i've restored GPU_* wrapper for those
which got lost in yesterday's refactor.

We might change the way how stuff is being drawn, but it shouldn't be mixed
into this particular patch (the drawing is same as in 2.80, that part did
not change).

Guess this is fine then.
Re point size - right, didn't mean to say that this patch should fix it, just something to check on.

This revision is now accepted and ready to land.Wed, Sep 18, 11:11 AM