\0;115;0cFix T52679: Hole in bake normal
ClosedPublic

Authored by Sergey Sharybin (sergey) on Tue, Sep 12, 11:17 AM.

Details

Summary

In fact, any type of baking might have caused holes in mesh.

The issue was caused by zspan_scanconvert() attempting to get order of traversal
'a-priori', which might have failed if check happens at the "tip" of span where
zspan->span1[sn1] == zspan->span2[sn1].

Didn't see anything bad on making it a check when iterating over scanlines and
pick minimal span based on current scanline. It's slower, but unlikely to cause
measurable difference. Quality should stay the same unless i'm missing something.

Diff Detail

Repository
rB Blender

Makes sense to me.

You could fix the other functions in this file that have the same code, but they would be removed in 2.8 along with Blender Internal so it doesn't matter so much.

This revision is now accepted and ready to land.Tue, Sep 12, 12:39 PM

Thanks for review.

P.S. Wonder how that rubbish appeared in the title of code review, gonna check my emacs...

This revision was automatically updated to reflect the committed changes.