T52586: User can no longer add current scene as scene strip
ClosedPublic

Authored by Danrae Pray (spockTheGray) on Nov 20 2017, 3:30 AM.

Details

Summary

T52586: User can no longer add current scene as scene strip.

Diff Detail

Repository
rB Blender
Campbell Barton (campbellbarton) requested changes to this revision.Nov 20 2017, 3:40 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/makesrna/RNA_enum_types.h
241

Would prefer same prefix, eg: RNA_scene_without_active_itemf

source/blender/windowmanager/intern/wm_operators.c
3997

It would be more flexible to pass in a function and user_data (common convention in Blender),

This can then check each item, filtering it based on it's own logic.

See: source/blender/blenlib/intern/BLI_kdtree.c:304

This revision now requires changes to proceed.Nov 20 2017, 3:40 AM

Ah ok - yeah, that's a better idea. I'll take a look at BLI_kdtree.c then. thanks!

Updated rna_id_itemf() so it takes an optional filter function / data as args, moved filter logic to custom func, and fixed custom RNA_*_itemf() name.

Danrae Pray (spockTheGray) marked 2 inline comments as done.Nov 20 2017, 2:39 PM

@Campbell Barton (campbellbarton) Oh gosh lol - not sure if I was supposed to mark the inline comments as 'Done' to notify you that I updated it or if you were supposed to mark those after you review changes (still learning how phab works haha)... anywho, thanks for the feedback - I updated w/ some changes.

This revision is now accepted and ready to land.Nov 21 2017, 6:37 AM