This patch addresses a crash in Freestyle in the Blender 2.8 branch when using the line renderer with Cycles.
The crash occurs in a call of RNA_property_copy() -- see the removed part in the patch (the old code was working in 2.7x but seems no longer valid in the 2.8 branch). The modified part of the code is intended to copy the Cycles options from one scene to another, so that the settings in the user-defined scene are used also for a temporary scene auto-generated by Freestyle for rendering of stylized lines.
The proposed revision changes two things:
- The way how the Cycles settings are copied. Now only the Cycles options relevant for Freestyle stroke rendering are explicitly listed in the code and copied one after another.
- The timing when the copying is done. The old code was doing the copy operation in a wrong place, and copying was unnecessarily repeated for every single Freestyle stoke.