Page MenuHome

Fix for missing "Use Freestyle" toggle in the Cycles "Layer" options panel.
ClosedPublic

Authored by Tamito Kajiyama (kjym3) on Feb 7 2018, 9:36 AM.

Details

Diff Detail

Repository
rB Blender

Event Timeline

@Dalai Felinto (dfelinto) made these changes, but fix looks good to commit.

This revision is now accepted and ready to land.Feb 7 2018, 11:48 AM

If Freestyle is False for the scene (bpy.context.scene.render.use_freestyle) will this option still work per-layer? If not you should at least deactivate the pass.

That said, I don't see this option in master either when using Cycles. Where is it? I feel like I'm missing something obvious, yet I can't get much out of git blame --author=dfelinto ui.py.

I think that users are simply working in master without this.
Freestyle Linesets are defined per renderlayer. When no lineset is created or enabled in a renderlayer, no freestyle stroke rendering is done for this renderlayer.
For users, deactivate all linesets is equal to deactivate freestyle pass.

When using Freestyle, you may create several renderlayers based on same scene layers, just to have passes relative to different linesets.

I think that absence of Freestyle pass for Cycles was based on an idea to make it evolved in order to create one pass par lineset for compositing.

Indeed it seems this is not exposed in the UI for Cycles in master either, it's only there for Blender Internal. So ideally both master and blender2.8 should be fixed.

Thanks Brecht and Dalai for the prompt reviews. I was not aware the "Use Freestyle" option was missing also in master. My bad, sorry Dalai for the confusion.

Now the patch is based on master. If this revision is considered okay, I will commit it to master and merge master to the blender2.8 branch.

(The revision is updated using a diff file instead of relying on Arcanist. I tried to rebase my local branch for the patch from blender2.8 to master but got too many merge conflicts.)

Tamito Kajiyama (kjym3) requested review of this revision.Feb 8 2018, 4:30 PM

Sounds good to me.

This revision is now accepted and ready to land.Feb 8 2018, 4:31 PM
This revision was automatically updated to reflect the committed changes.