Page MenuHome

Fix T53857: Incorrect framerate for videos imported from OBS
ClosedPublic

Authored by Sergey Sharybin (sergey) on Feb 26 2018, 4:43 PM.

Details

Summary

This is an issue with which value to trust: fps vs. tbr. They both cam be
somewhat broken. Currently the idea is:

  • If file was saved with FFmpeg AND we are decoding with FFmpeg we trust tbr.
  • If we are decoding with Libav we use fps (there does not seem to be tbr in Libav, unless i'm missing something).
  • All other cases we use fps.

Seems to work all good for files from T53857, T54148 and T51153. Ideally we
would need to collect some amount of regression files to make further tweaks
more scientific.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) retitled this revision from \0;115;0cFix T53857: Incorrect framerate for videos imported from OBS to Fix T53857: Incorrect framerate for videos imported from OBS.Feb 26 2018, 4:58 PM

Besides typos noted below, LGTM.

intern/ffmpeg/ffmpeg_compat.h
58

I’d expect this to be AV_USING_LIBAV ?

472

"fall back", not "toll back", I assume?

This revision is now accepted and ready to land.Feb 26 2018, 5:11 PM