Structural cleanup for the compositor
AbandonedPublic
Actions

Authored by Thomas Dinges (dingto) on Feb 11 2014, 1:11 PM.

Details

Reviewers

Lukas Toenne (lukastoenne)
Monique Dewanchand (mdewanchand)
Jeroen Bakker (jbakker)
Sergey Sharybin (sergey)

Summary

Many parts of the compositor are unnecessarily complicated. This patch
aims at reducing the complexity of writing nodes and making the code
more transparent.

A number of further improvements can be made beyond this patch, but
since it touches all of the node files i consider it preferable to make
a checkpoint and get this approved and verified first.

Layered structure

Currently the compositor mixes nodes (internal copies from bNode) and
actual operations (elementary executable components) in the same graph,
which leads to lots of implicit type assumptions and confusing
distinctions.

Separate these graphs from each other:

NodeGraph: internal representation of the bNodeTree DNA data. Most nodes have a 1:1 class equivalent, except for a few nodes (groups, switch, muted nodes) which are replaced by simple proxies.
Operations graph (currently still "ExecutionSystem"):

Actual implementations, generated from the NodeGraph in a second step.
Nodes define a conversion method to transform themselves into a set of
operations based on data copied from DNA nodes.

Dedicated classes: What happens Where

Many functions are in awkward places and pass through multiple different
classes before the final implementation (e.g. node->addLink wrapping
execution system function).

In particular the construction of the NodeGraph and ExecutionSystem
(operation graph) should be handled by compiler classes. These can
store temporary state, like socket maps, and are created only as local
variables for converting DNA nodes to node graph and node graph to
operations graph respectively. That way the graph structures themselves
are largely free of the intricacies of how these structures are
converted and easier to understand.

Diff Detail

Branch: compo_structural_cleanup

Event Timeline

Separating Node and Operation graphs.

New socket and connection classes replace the shared classes,
InputSocket, OutputSocket, SocketConnection are only used for NodeGraph
now (to be renamed later).

This ensures we don't get confused at any point about what type of
socket or connection a function expects. A lot of bloated type checking
code (e.g. isOperation) becomes unnecessary. Many previously shared
properties are now clearly assigned to just one of these types (e.g.
bNode/bNodeTree pointers only exist in NodeGraph, while
determineResolution is only used in operations).

Renamed graph classes to follow a common naming pattern throughout node
and graph structures:

NodeGraph / OpGraph: base container class
Node / Operation: main components
NodeInput, NodeOutput / OpInput, OpOutput: sockets in node/operation
NodeLink, OpLink: connection between sockets

All classes now have proper names, with the exception of ExecutionSystem
(OpGraph), which still needs some reorganization for the
ExecutionGroups.

Changed the compiler and context arguments of the convertToOperations
method from pointers to references.

Moved all construction logic for operations from the ExecutionSystem
into the NodeCompiler class.

The idea is that the compiler is responsible for creating all the
operations, connections and groups and for performing any optimizations
(such as removing unused operations, resolving proxies, later constant
folding). The ExecutionSystem should see the operations graph as
immutable and not have to modify the structure itself.

The functionality in the compiler may be split up a bit further later
for clarity, e.g. store actual data in a dedicated OpGraph container.

Removed explicit OpLink instance from the ExecutionSystem and operation
input/output classes.

For evaluating the compositor operations a single input pointer to the
connected output is perfectly sufficient. Actual connection list is only
used internally in the compiler now.

NodeLink made into an internal class of the NodeGraph and connections
list removed from NodeOutput.

Just like with operations there really is no need to access node links
directly from outputs. The node graph in its construction method can
access the internal link vector, for nodes the connection status of
output sockets is irrelevant.

Fix for Blur operations: use a copy of the NodeBlurData instead of keeping a pointer

Fixed the DebugInfo class used for graphviz dumps

Divided the NodeCompiler class into a basic abstract interface and an implementation class NodeCompilerImpl. The reason for this is to make the convertToOperations methods in nodes as simple as possible by keeping only the main public functions in the NodeCompiler interface and hide all the details of storage and optimization functions in the implementation class.

Sanity for the ExecutionGroup::addOperation function. This things was pure madness, considering what it actually does: collect input operations into groups, using a few exceptions based on operation complexity settings.

Fix for order of determineResolutions, read/write buffering and grouping
processes.

These have to be performed in the correct order to ensure that
additional operations are included in groups and that resolutions for
all the operations are calculated correctly.

Bring back node groups, by adding a method to resolve proxy operations.

Proxies can be added by any node. For groups they are used to provide
a connection of the group instance with outside nodes. After all nodes
have been converted to operations, the proxy operations are resolved,
i.e. all downstream connections are replaced by going back to the first
non-proxy output.

A bunch of cleanup in addition to this: All optimization procedures that
happen after the main node conversion now have their own little
functions to avoid ballooning up the main convertToOperations method.

Pruning unreachable operations: This removes up any operations that will
never be executed to clean up the operations graph.

Merge branch 'master' into compo_structural_cleanup

Fixed bug in complex operation buffering, this was not properly checking
connections for input sockets and connecting them to arbitrary write
buffer operations.

Naming of the Node:

End of january we had a discussion in the institute that you really wanted that the compositor would have an own language with a compiler. This is a good idea but a step too far for now.
In this path you reserve the next Classes: Compiler, Operation that are better suited for this future project.

Also compilers normally works autonomous, your implementation of the compiler is strictly integrated using delegates to the source. The design pattern that is closest to your implementation are Factory, or builder. In the anti-patterns it is better suited for DTO/DTS.

I would rather see that the compiler (or what name that it will have) to be a static implementation. As now for no usage the compiler is passed to every node. You could also seperate the public interface and the friend interface better when using two static classes.

I do see the benefits for this splice, but still need to look if it fits the proposal we are working on. In this proposal there will be a forth data structure (Tiles+dependencies) that will be generated.

Missing documentation or outdated documentation (overall design in the COM_compositor.h etc)
We should stick to a single name policy (Link or Connection, not both)
Do not use short hand names as it is not clear (use Operation iso Op)
We think that NodeOperation is a better name than Operation (a bit too generic) see above for the explanation
The name Graph is wrong as it really is not a graph (nodes are connected with one or multiple sockets, this doesn't fit in the idea of a graph too well), that is also why we called it a system.

No matter in which direction we will go, the current compositor code is very difficult to understand, and imho Lukas patch is a big step into the right direction.

For the record, we do not disagree with the implementation,
but we should really concern about the naming and future extensibility.

btw. has anyone looked at the time it takes to build the operation tree with this design? I haven't seen any records on that. I always used 0.2 seconds for a complex tree on a 2Ghz machine as a reference.

Some quick replies on @Jeroen Bakker (jbakker) comment.

So, first things first. Don't see anything bad about laying bits needed for custom language (it could be based om OSL or even be own language or so, doesn't really matter at this point) on the early stages. IMO, that's gonna to save some time doing re-design once including all the bits we'll need in the future rather than including features one-by-one. Maybe too much vague explanation, but hope you got the point :)

One thing here tho, we do not necessarily will put all the bits now, we just need to be sure further extending of the compo wouldn't lead to need of its re-designing.

I'll leave all the design patterns up to you guys ;) Mainly because design pattern is just a tool, there's never single pattern for the particular task. I'll totally trust Lukas here he's much more to C++ than i am.

Agree on the missing documentation, it always was (and will be? :( ) an issue in blender.. However, wouldn't be so much polar about this to Lukas. Where's the documentation about details of OpenCL implementation (bunch of methods with undocumented arguments and so). Also, spending time on putting documentation to the patch which has probability of being rejected.. IMO it's not a huge deal to copy-paste stuff from the commit message (which is rather explicit here) to the code once we consider code-wise the patch is good.

Also agree on Link vs. Connection. But one thing here -- compo violated name from the very beginning. "Connection" was introduced by the new design, we used to (and still using in DNA and editors) use "Link". Go figure ;)

Short names agree in general (i love verbose names and always use them in Libmv). But not so much fussed about using shorten versions which are common in the computer science (Op, Ctx and so on).

NodeOperation vs. Operation eeeh. That's tricky. Operation sounds more generic, however NodeOperation is somehow misleading as well by some sort of implicit mention in the name that it's something to do with the node, which doesn't really exist. It's more like ImageprocessOperation or so. Could be some better name.

Graph is even more tricky question. Speaking of generality of the names, System is really vague and too general ;) And didn't really get why graph is wrong here? It's a heterogeneous multi-graph ;)

Just own thoughts about naming :)

Please all look at http://git.blender.org/gitweb/gitweb.cgi/blender.git/blob/HEAD:/source/blender/compositor/COM_compositor.h before commenting on documentation!

IMO this patch changes the structure and the overview documentation has not been updated. If we don't update the documentation in this file we should remove the documentation at all. Making it harder for people to understand the code itself. They need to reverse engineer the working via code? result => getting only experienced people in the compositor, taking longer time for people to get used to the system.

This is not the way even for big Open source project how they should work as you all agree that event this file cannot be updated!

One big issue with Blender (and has always been) is getting new developers in. Blender2.5 did a good job in that, and if we also want this for this patch to happen we should really look at our target audience. For who should the code be clear. Experienced Blender devs or Newby's. The part that this patch is addressing in implemeting new nodes. normally new nodes (in typically studios) are implemented by not core blender developers. So if we want to address this we should focus on our target audience.

When it will be possible to create node-plugins in blender the API reflects only a part of the full API and that should be clear. IMO the moving of the code to a seperate class is OK. Naming it a compiler is not OK. Just look for a reference to the Nuke API that is a well-named API. And in stead of a Compiler class IMO it would be better to use a static class or a bunch of methods in a seperate namespace.

Well when introducing a compiler I would expect that there will be an Operand. By that time "Op" can mean two things.
IMO class names and methods should be full names for clarification.

I agree that Connection is not a blender's name and Link is correct. I only say when changing Link to Connection what this patch introduces is the other way around. Saying that Blender's internal name (Link) is not correct and Connection is correct!

IMO when changing naming convention you should do it for the whole module. As this patch only addresses some parts of the module, we will get a hybrid format Not saying to new developers what is the correct one.

But if you all don't see the big picture of the impact of the naming-convention of this patch on future development, do not expect Blender's compositor to evolve. We are spending a lot of time and community money on doing things that is not in the right direction.

Having said this, I still agree with the implementation, only the naming is not well thought about and implemented and there is no vision or design behind this patch. My concerns are stated here. If the community thinks that I am incorrect, like a lot of developers is pointing out, please be aware that this could be a bigger issue that they can oversee.

Well, was a bit of misunderstanding about some things, but don't want to spend more time describing what i meant.

So if the issue is just in naming, then few things:

Let's making sure the patch doesn't increase entropy of link vs. connection naming (as in: patch uses link all over the new code)
Get rid of connection name as a separate patch (current master already mixes the names here)
If "Compiler" is not considered good enough -- tell what would fit into the updated design. We can not judge on how good or bad name would be from the bigger design changes POV when we don't know exactly what's gonna to be changed..
Op vs. Operation -- lets choose full name. Think neither me nor Lukas really fussed using full name here.
NodeOperation vs. Operation would also depend on how updated design will look like. It might be neither of this names fitting here really.

Would it solve the issues with the patch? Currently i'm not even sure what are exact stoppers for the patch, or whether it's just to be re-considered from scratch or what.

Merge branch 'master' into compo_structural_cleanup

Updated new Corner Pin node to use the compiler

Cleanup: Changed all uses of "connection" to "link" for shorter names and consistency with the rest of Blender code.

Cleanup: Renamed class names with shortended "Op" prefix to full "Operation" names.

Note: Link classes inside NodeGraph and NodeCompiler are now simply named "Link", since these are internal helper structs for these graph constructors only, no need to use an additional prefix.

Renamed Operation back to NodeOperation.

Discussion about this name change has come to no definite conclusion,
decision was to retain the current naming for now.

Hi Lukas, good work.

Concerning the compiler I would suggest to start with the psuedo you shared with me last week. It used the names ...Converter and ...Builder (at least I remember these names). We can than merge the code to head.

As discussed we don't believe that these names are final, but we can collect some feedback when working with the system. We can discuss the implementation (static in stead of instance) in a later stage.

Jeroen

Renaming the compiler class(es) according to requests by AtMind.

NodeCompiler -> NodeConverter: The 'compiler' name was contested as being out of place for a graph construction helper.
NodeCompilerImpl -> NodeOperationBuilder: This contains the innards of the actual construction methods, storage containers for operations created by nodes and optimization functions for finalizing the result

Use NodeConverter as an interface wrapper around the NodeOperationBuilder instead of an abstract base class.

Inline documentation for the NodeConverter methods. Documentation may be added to other classes, but this is the most important since it is used very frequently by all the nodes and needs to be well understood by node developers.

This was commited, so can be closed. ;)

Thomas Dinges (dingto) abandoned this revision.Apr 27 2014, 8:48 PM

Lukas Toenne (lukastoenne) mentioned this in rBS7ee9de29a623: Fix T38487: Wrapped translate node in combination with other buffered nodes….Nov 20 2014, 9:17 AM

Lukas Toenne (lukastoenne) mentioned this in rBS005dabbd9ad5: Fix T39799: Backdrop (compositor) ignores alpha..Nov 20 2014, 9:33 AM

Large Diff

This large diff affects 253 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
M		source/blender/compositor/CMakeLists.txt (46 lines)
M		source/blender/compositor/COM_compositor.h (4 lines)
M		source/blender/compositor/COM_defines.h (2 lines)
M		source/blender/compositor/intern/COM_CPUDevice.cpp (2 lines)
M		source/blender/compositor/intern/COM_ChannelInfo.h (10 lines)
M		source/blender/compositor/intern/COM_CompositorContext.h (6 lines)
M		source/blender/compositor/intern/COM_Converter.h (34 lines)
M		source/blender/compositor/intern/COM_Converter.cpp (151 lines)
M		source/blender/compositor/intern/COM_Debug.h (31 lines)
M		source/blender/compositor/intern/COM_Debug.cpp (141 lines)
M		source/blender/compositor/intern/COM_ExecutionGroup.h (49 lines)
M		source/blender/compositor/intern/COM_ExecutionGroup.cpp (104 lines)
M		source/blender/compositor/intern/COM_ExecutionSystem.h (91 lines)
M		source/blender/compositor/intern/COM_ExecutionSystem.cpp (230 lines)
D	M	source/blender/compositor/intern/COM_ExecutionSystemHelper.h (126 lines)
D	M	source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp (171 lines)
D	M	source/blender/compositor/intern/COM_InputSocket.h (149 lines)
D	M	source/blender/compositor/intern/COM_InputSocket.cpp (159 lines)
M		source/blender/compositor/intern/COM_MemoryBuffer.h (1 line)
M		source/blender/compositor/intern/COM_MemoryBuffer.cpp (5 lines)
M		source/blender/compositor/intern/COM_MemoryProxy.h (1 line)
M		source/blender/compositor/intern/COM_Node.h (234 lines)
M		source/blender/compositor/intern/COM_Node.cpp (235 lines)
D	M	source/blender/compositor/intern/COM_NodeBase.h (185 lines)
D	M	source/blender/compositor/intern/COM_NodeBase.cpp (96 lines)
A	M	source/blender/compositor/intern/COM_NodeConverter.h (103 lines)
A	M	source/blender/compositor/intern/COM_NodeConverter.cpp (131 lines)
A	M	source/blender/compositor/intern/COM_NodeGraph.h (109 lines)
A	M	source/blender/compositor/intern/COM_NodeGraph.cpp (280 lines)
M		source/blender/compositor/intern/COM_NodeOperation.h (175 lines)
M		source/blender/compositor/intern/COM_NodeOperation.cpp (138 lines)
A	M	source/blender/compositor/intern/COM_NodeOperationBuilder.h (158 lines)
A	M	source/blender/compositor/intern/COM_NodeOperationBuilder.cpp (661 lines)
M		source/blender/compositor/intern/COM_OpenCLDevice.h (2 lines)
M		source/blender/compositor/intern/COM_OpenCLDevice.cpp (2 lines)
D	M	source/blender/compositor/intern/COM_OutputSocket.h (84 lines)
D	M	source/blender/compositor/intern/COM_OutputSocket.cpp (119 lines)
V		source/blender/compositor/intern/{COM_SingleThreadedNodeOperation.h → COM_SingleThreadedOperation.h}
V		source/blender/compositor/intern/{COM_SingleThreadedNodeOperation.cpp → COM_SingleThreadedOperation.cpp}
V		source/blender/compositor/intern/{COM_SingleThreadedOperation.h ← COM_SingleThreadedNodeOperation.h} (8 lines)
V		source/blender/compositor/intern/{COM_SingleThreadedOperation.cpp ← COM_SingleThreadedNodeOperation.cpp} (12 lines)
D	M	source/blender/compositor/intern/COM_Socket.h (100 lines)
D	M	source/blender/compositor/intern/COM_Socket.cpp (68 lines)
D	M	source/blender/compositor/intern/COM_SocketConnection.h (127 lines)
D	M	source/blender/compositor/intern/COM_SocketConnection.cpp (95 lines)
M		source/blender/compositor/intern/COM_WorkScheduler.cpp (10 lines)
M		source/blender/compositor/nodes/COM_AlphaOverNode.h (2 lines)
M		source/blender/compositor/nodes/COM_AlphaOverNode.cpp (24 lines)
M		source/blender/compositor/nodes/COM_BilateralBlurNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BilateralBlurNode.cpp (14 lines)
M		source/blender/compositor/nodes/COM_BlurNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BlurNode.cpp (98 lines)
M		source/blender/compositor/nodes/COM_BokehBlurNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BokehBlurNode.cpp (39 lines)
M		source/blender/compositor/nodes/COM_BokehImageNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BokehImageNode.cpp (10 lines)
M		source/blender/compositor/nodes/COM_BoxMaskNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BoxMaskNode.cpp (40 lines)
M		source/blender/compositor/nodes/COM_BrightnessNode.h (2 lines)
M		source/blender/compositor/nodes/COM_BrightnessNode.cpp (13 lines)
M		source/blender/compositor/nodes/COM_ChannelMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ChannelMatteNode.cpp (56 lines)
M		source/blender/compositor/nodes/COM_ChromaMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ChromaMatteNode.cpp (58 lines)
M		source/blender/compositor/nodes/COM_ColorBalanceNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorBalanceNode.cpp (19 lines)
M		source/blender/compositor/nodes/COM_ColorCorrectionNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorCorrectionNode.cpp (14 lines)
M		source/blender/compositor/nodes/COM_ColorCurveNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorCurveNode.cpp (34 lines)
M		source/blender/compositor/nodes/COM_ColorMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorMatteNode.cpp (57 lines)
M		source/blender/compositor/nodes/COM_ColorNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorNode.cpp (9 lines)
M		source/blender/compositor/nodes/COM_ColorRampNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorRampNode.cpp (29 lines)
M		source/blender/compositor/nodes/COM_ColorSpillNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorSpillNode.cpp (21 lines)
M		source/blender/compositor/nodes/COM_ColorToBWNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ColorToBWNode.cpp (13 lines)
A	M	source/blender/compositor/nodes/COM_CombineColorNode.h (74 lines)
A	M	source/blender/compositor/nodes/COM_CombineColorNode.cpp (93 lines)
D	M	source/blender/compositor/nodes/COM_CombineHSVANode.h (38 lines)
D	M	source/blender/compositor/nodes/COM_CombineHSVANode.cpp (46 lines)
D	M	source/blender/compositor/nodes/COM_CombineRGBANode.h (37 lines)
D	M	source/blender/compositor/nodes/COM_CombineRGBANode.cpp (64 lines)
D	M	source/blender/compositor/nodes/COM_CombineYCCANode.h (37 lines)
D	M	source/blender/compositor/nodes/COM_CombineYCCANode.cpp (45 lines)
D	M	source/blender/compositor/nodes/COM_CombineYUVANode.h (37 lines)
D	M	source/blender/compositor/nodes/COM_CombineYUVANode.cpp (40 lines)
M		source/blender/compositor/nodes/COM_CompositorNode.h (2 lines)
M		source/blender/compositor/nodes/COM_CompositorNode.cpp (29 lines)
M		source/blender/compositor/nodes/COM_ConvertAlphaNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ConvertAlphaNode.cpp (12 lines)
M		source/blender/compositor/nodes/COM_CornerPinNode.h (2 lines)
M		source/blender/compositor/nodes/COM_CornerPinNode.cpp (35 lines)
M		source/blender/compositor/nodes/COM_CropNode.h (2 lines)
M		source/blender/compositor/nodes/COM_CropNode.cpp (9 lines)
M		source/blender/compositor/nodes/COM_DefocusNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DefocusNode.cpp (96 lines)
M		source/blender/compositor/nodes/COM_DespeckleNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DespeckleNode.cpp (25 lines)
M		source/blender/compositor/nodes/COM_DifferenceMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DifferenceMatteNode.cpp (32 lines)
M		source/blender/compositor/nodes/COM_DilateErodeNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DilateErodeNode.cpp (101 lines)
M		source/blender/compositor/nodes/COM_DirectionalBlurNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DirectionalBlurNode.cpp (12 lines)
M		source/blender/compositor/nodes/COM_DisplaceNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DisplaceNode.cpp (17 lines)
M		source/blender/compositor/nodes/COM_DistanceMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DistanceMatteNode.cpp (83 lines)
M		source/blender/compositor/nodes/COM_DoubleEdgeMaskNode.h (2 lines)
M		source/blender/compositor/nodes/COM_DoubleEdgeMaskNode.cpp (11 lines)
M		source/blender/compositor/nodes/COM_EllipseMaskNode.h (2 lines)
M		source/blender/compositor/nodes/COM_EllipseMaskNode.cpp (42 lines)
M		source/blender/compositor/nodes/COM_FilterNode.h (2 lines)
M		source/blender/compositor/nodes/COM_FilterNode.cpp (20 lines)
M		source/blender/compositor/nodes/COM_FlipNode.h (2 lines)
M		source/blender/compositor/nodes/COM_FlipNode.cpp (12 lines)
M		source/blender/compositor/nodes/COM_GammaNode.h (2 lines)
M		source/blender/compositor/nodes/COM_GammaNode.cpp (10 lines)
M		source/blender/compositor/nodes/COM_GlareNode.h (2 lines)
M		source/blender/compositor/nodes/COM_GlareNode.cpp (46 lines)
D	M	source/blender/compositor/nodes/COM_GroupNode.h (61 lines)
D	M	source/blender/compositor/nodes/COM_GroupNode.cpp (216 lines)
M		source/blender/compositor/nodes/COM_HueSaturationValueCorrectNode.h (2 lines)
M		source/blender/compositor/nodes/COM_HueSaturationValueCorrectNode.cpp (38 lines)
M		source/blender/compositor/nodes/COM_HueSaturationValueNode.h (2 lines)
M		source/blender/compositor/nodes/COM_HueSaturationValueNode.cpp (38 lines)
M		source/blender/compositor/nodes/COM_IDMaskNode.h (2 lines)
M		source/blender/compositor/nodes/COM_IDMaskNode.cpp (19 lines)
M		source/blender/compositor/nodes/COM_ImageNode.h (5 lines)
M		source/blender/compositor/nodes/COM_ImageNode.cpp (170 lines)
M		source/blender/compositor/nodes/COM_InpaintNode.h (2 lines)
M		source/blender/compositor/nodes/COM_InpaintNode.cpp (10 lines)
M		source/blender/compositor/nodes/COM_InvertNode.h (2 lines)
M		source/blender/compositor/nodes/COM_InvertNode.cpp (10 lines)
M		source/blender/compositor/nodes/COM_KeyingNode.h (22 lines)
M		source/blender/compositor/nodes/COM_KeyingNode.cpp (276 lines)
M		source/blender/compositor/nodes/COM_KeyingScreenNode.h (2 lines)
M		source/blender/compositor/nodes/COM_KeyingScreenNode.cpp (22 lines)
M		source/blender/compositor/nodes/COM_LensDistortionNode.h (2 lines)
M		source/blender/compositor/nodes/COM_LensDistortionNode.cpp (33 lines)
M		source/blender/compositor/nodes/COM_LuminanceMatteNode.h (2 lines)
M		source/blender/compositor/nodes/COM_LuminanceMatteNode.cpp (39 lines)
M		source/blender/compositor/nodes/COM_MapRangeNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MapRangeNode.cpp (34 lines)
M		source/blender/compositor/nodes/COM_MapUVNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MapUVNode.cpp (15 lines)
M		source/blender/compositor/nodes/COM_MapValueNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MapValueNode.cpp (15 lines)
M		source/blender/compositor/nodes/COM_MaskNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MaskNode.cpp (16 lines)
M		source/blender/compositor/nodes/COM_MathNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MathNode.cpp (18 lines)
M		source/blender/compositor/nodes/COM_MixNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MixNode.cpp (25 lines)
M		source/blender/compositor/nodes/COM_MovieClipNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MovieClipNode.cpp (78 lines)
M		source/blender/compositor/nodes/COM_MovieDistortionNode.h (2 lines)
M		source/blender/compositor/nodes/COM_MovieDistortionNode.cpp (15 lines)
D	M	source/blender/compositor/nodes/COM_MuteNode.h (51 lines)
D	M	source/blender/compositor/nodes/COM_MuteNode.cpp (175 lines)
M		source/blender/compositor/nodes/COM_NormalNode.h (2 lines)
M		source/blender/compositor/nodes/COM_NormalNode.cpp (27 lines)
M		source/blender/compositor/nodes/COM_NormalizeNode.h (2 lines)
M		source/blender/compositor/nodes/COM_NormalizeNode.cpp (9 lines)
M		source/blender/compositor/nodes/COM_OutputFileNode.h (2 lines)
M		source/blender/compositor/nodes/COM_OutputFileNode.cpp (45 lines)
M		source/blender/compositor/nodes/COM_PixelateNode.h (2 lines)
M		source/blender/compositor/nodes/COM_PixelateNode.cpp (21 lines)
M		source/blender/compositor/nodes/COM_PlaneTrackDeformNode.h (2 lines)
M		source/blender/compositor/nodes/COM_PlaneTrackDeformNode.cpp (62 lines)
M		source/blender/compositor/nodes/COM_RenderLayersNode.h (4 lines)
M		source/blender/compositor/nodes/COM_RenderLayersNode.cpp (101 lines)
M		source/blender/compositor/nodes/COM_RotateNode.h (2 lines)
M		source/blender/compositor/nodes/COM_RotateNode.cpp (21 lines)
M		source/blender/compositor/nodes/COM_ScaleNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ScaleNode.cpp (71 lines)
A	M	source/blender/compositor/nodes/COM_SeparateColorNode.h (74 lines)
A	M	source/blender/compositor/nodes/COM_SeparateColorNode.cpp (117 lines)
D	M	source/blender/compositor/nodes/COM_SeparateHSVANode.h (39 lines)
D	M	source/blender/compositor/nodes/COM_SeparateHSVANode.cpp (44 lines)
D	M	source/blender/compositor/nodes/COM_SeparateRGBANode.h (37 lines)
D	M	source/blender/compositor/nodes/COM_SeparateRGBANode.cpp (76 lines)
D	M	source/blender/compositor/nodes/COM_SeparateYCCANode.h (38 lines)
D	M	source/blender/compositor/nodes/COM_SeparateYCCANode.cpp (46 lines)
D	M	source/blender/compositor/nodes/COM_SeparateYUVANode.h (38 lines)
D	M	source/blender/compositor/nodes/COM_SeparateYUVANode.cpp (42 lines)
M		source/blender/compositor/nodes/COM_SetAlphaNode.h (2 lines)
M		source/blender/compositor/nodes/COM_SetAlphaNode.cpp (16 lines)
M		source/blender/compositor/nodes/COM_SocketProxyNode.h (13 lines)
M		source/blender/compositor/nodes/COM_SocketProxyNode.cpp (94 lines)
M		source/blender/compositor/nodes/COM_SplitViewerNode.h (2 lines)
M		source/blender/compositor/nodes/COM_SplitViewerNode.cpp (25 lines)
M		source/blender/compositor/nodes/COM_Stabilize2dNode.h (2 lines)
M		source/blender/compositor/nodes/COM_Stabilize2dNode.cpp (61 lines)
M		source/blender/compositor/nodes/COM_SwitchNode.h (2 lines)
M		source/blender/compositor/nodes/COM_SwitchNode.cpp (26 lines)
M		source/blender/compositor/nodes/COM_TextureNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TextureNode.cpp (37 lines)
M		source/blender/compositor/nodes/COM_TimeNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TimeNode.cpp (11 lines)
M		source/blender/compositor/nodes/COM_TonemapNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TonemapNode.cpp (11 lines)
M		source/blender/compositor/nodes/COM_TrackPositionNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TrackPositionNode.cpp (27 lines)
M		source/blender/compositor/nodes/COM_TransformNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TransformNode.cpp (47 lines)
M		source/blender/compositor/nodes/COM_TranslateNode.h (2 lines)
M		source/blender/compositor/nodes/COM_TranslateNode.cpp (53 lines)
M		source/blender/compositor/nodes/COM_ValueNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ValueNode.cpp (9 lines)
M		source/blender/compositor/nodes/COM_VectorBlurNode.h (2 lines)
M		source/blender/compositor/nodes/COM_VectorBlurNode.cpp (17 lines)
M		source/blender/compositor/nodes/COM_VectorCurveNode.h (2 lines)
M		source/blender/compositor/nodes/COM_VectorCurveNode.cpp (12 lines)
M		source/blender/compositor/nodes/COM_ViewLevelsNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ViewLevelsNode.cpp (52 lines)
M		source/blender/compositor/nodes/COM_ViewerNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ViewerNode.cpp (30 lines)
M		source/blender/compositor/nodes/COM_ZCombineNode.h (2 lines)
M		source/blender/compositor/nodes/COM_ZCombineNode.cpp (96 lines)
M		source/blender/compositor/operations/COM_BlurBaseOperation.h (7 lines)
M		source/blender/compositor/operations/COM_BlurBaseOperation.cpp (34 lines)
M		source/blender/compositor/operations/COM_CompositorOperation.cpp (1 line)
M		source/blender/compositor/operations/COM_FastGaussianBlurOperation.cpp (14 lines)
M		source/blender/compositor/operations/COM_GaussianAlphaXBlurOperation.cpp (6 lines)
M		source/blender/compositor/operations/COM_GaussianAlphaYBlurOperation.cpp (6 lines)
M		source/blender/compositor/operations/COM_GaussianBokehBlurOperation.cpp (34 lines)
M		source/blender/compositor/operations/COM_GaussianXBlurOperation.cpp (4 lines)
M		source/blender/compositor/operations/COM_GaussianYBlurOperation.cpp (4 lines)
M		source/blender/compositor/operations/COM_GlareBaseOperation.h (4 lines)
M		source/blender/compositor/operations/COM_GlareBaseOperation.cpp (6 lines)
M		source/blender/compositor/operations/COM_MathBaseOperation.cpp (2 lines)
M		source/blender/compositor/operations/COM_MixOperation.cpp (2 lines)
M		source/blender/compositor/operations/COM_OutputFileOperation.h (4 lines)
M		source/blender/compositor/operations/COM_OutputFileOperation.cpp (1 line)
M		source/blender/compositor/operations/COM_PreviewOperation.h (2 lines)
M		source/blender/compositor/operations/COM_PreviewOperation.cpp (1 line)
M		source/blender/compositor/operations/COM_ReadBufferOperation.h (1 line)
M		source/blender/compositor/operations/COM_SetVectorOperation.h (2 lines)
M		source/blender/compositor/operations/COM_SocketProxyOperation.h (6 lines)
M		source/blender/compositor/operations/COM_SocketProxyOperation.cpp (18 lines)
M		source/blender/compositor/operations/COM_SplitOperation.cpp (1 line)
M		source/blender/compositor/operations/COM_TextureOperation.h (4 lines)
M		source/blender/compositor/operations/COM_TextureOperation.cpp (6 lines)
M		source/blender/compositor/operations/COM_TonemapOperation.cpp (2 lines)
M		source/blender/compositor/operations/COM_ViewerOperation.h (2 lines)
M		source/blender/compositor/operations/COM_ViewerOperation.cpp (1 line)
M		source/blender/compositor/operations/COM_WriteBufferOperation.h (3 lines)
M		source/blender/makesdna/DNA_node_types.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	964	11112d4		Feb 11 2014, 1:11 PM	★	★
Diff 2	975	5b0f033	Separating Node and Operation graphs.	Feb 12 2014, 2:54 PM	★	★
Diff 3	995	910f4df	Renamed graph classes to follow a common naming pattern throughout node	Feb 13 2014, 3:39 PM	★	★
Diff 4	1000	42946c3	Changed the compiler and context arguments of the convertToOperations	Feb 14 2014, 4:48 PM	★	★
Diff 5	1005	42946c3	Moved all construction logic for operations from the ExecutionSystem	Feb 14 2014, 9:07 PM	★	★
Diff 6	1009	42946c3	Removed explicit OpLink instance from the ExecutionSystem and operation	Feb 15 2014, 11:42 AM	★	★
Diff 7	1010	42946c3	NodeLink made into an internal class of the NodeGraph and connections	Feb 15 2014, 1:28 PM	★	★
Diff 8	1022	42946c3	* Fix for Blur operations: use a copy of the NodeBlurData instead of keeping a pointer	Feb 16 2014, 9:55 AM	★	★
Diff 9	1025	42946c3	* Divided the NodeCompiler class into a basic abstract interface and an implementation class NodeCompilerImpl. The reason for this is to make the convertToOperations methods in nodes as simple as possible by keeping only the main public functions in the N	Feb 16 2014, 2:29 PM	★	★
Diff 10	1028	42946c3	Fix for order of determineResolutions, read/write buffering and grouping	Feb 16 2014, 5:22 PM	★	★
Diff 11	1029	42946c3	Bring back node groups, by adding a method to resolve proxy operations.	Feb 16 2014, 7:08 PM	★	★
Diff 12	1033	42946c3	Pruning unreachable operations: This removes up any operations that will	Feb 17 2014, 9:07 AM	★	★
Diff 13	1053	a6b8785	Merge branch 'master' into compo_structural_cleanup	Feb 19 2014, 11:00 AM	★	★
Diff 14	1254	4ae6c5c	Merge branch 'master' into compo_structural_cleanup	Mar 12 2014, 10:01 AM	★	★
Diff 15	1255	4ae6c5c	Cleanup: Changed all uses of "connection" to "link" for shorter names and consistency with the rest of Blender code.	Mar 12 2014, 10:17 AM	★	★
Diff 16	1256	4ae6c5c	Cleanup: Renamed class names with shortended "Op" prefix to full "Operation" names.	Mar 12 2014, 11:09 AM	★	★
Diff 17	1258	4ae6c5c	Renamed Operation back to NodeOperation.	Mar 12 2014, 12:53 PM	★	★
Diff 18	1303	a91247c	Renaming the compiler class(es) according to requests by AtMind.	Mar 19 2014, 8:40 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
70d64af7ef4c	56d5f7211e88	512b6a560100	Lukas Tönne	Use NodeConverter as an interface wrapper around the NodeOperationBuilder… (Show More…)	Mar 19 2014, 8:32 AM
512b6a560100	4f8b47a42c3b	4b33be70904c	Lukas Tönne	Inline documentation for the NodeConverter methods. (Show More…)	Mar 19 2014, 8:06 AM
4b33be70904c	74da5000e13a	b752b431e1cb	Lukas Tönne	Renaming the compiler class(es) according to requests by AtMind. (Show More…)	Mar 19 2014, 7:39 AM
b752b431e1cb	b3d8da0c9b4c	085fb32d2736 a91247c2b470	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup (Show More…)	Mar 19 2014, 6:28 AM
085fb32d2736	2e70f10ad630	f545abec8b9a	Lukas Tönne	Renamed Operation back to NodeOperation. (Show More…)	Mar 12 2014, 12:46 PM
f545abec8b9a	de1c7aac5d1b	a6840e6b4735	Lukas Tönne	Cleanup: Renamed class names with shortended "Op" prefix to full "Operation"… (Show More…)	Mar 12 2014, 11:02 AM
a6840e6b4735	7a4596a6e722	e4870f360f94	Lukas Tönne	Cleanup: Changed all uses of "connection" to "link" for shorter names and… (Show More…)	Mar 12 2014, 10:11 AM
e4870f360f94	0545032416d0	8d75c4f95d72 4ae6c5cd7799	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup (Show More…)	Mar 12 2014, 9:26 AM
8d75c4f95d72	3f255187784a	d238801be294 a89ef76136b8	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Mar 2 2014, 5:09 PM
d238801be294	e3e2c83180ae	2dfbe8b11134 fd553c5b7bdf	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Mar 2 2014, 4:07 PM
2dfbe8b11134	aa18e5232107	9f722f477210 3eabe064ab54	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Mar 1 2014, 6:50 PM
9f722f477210	754e06c5c6af	7596f3f4484b 64eea27533b8	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Feb 27 2014, 9:05 AM
7596f3f4484b	b05fa4fd648c	edda8417cc10 907be3632c60	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Feb 22 2014, 11:01 AM
edda8417cc10	b4a668ae739d	a02a6e961100 4789793f0903	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup	Feb 20 2014, 4:06 PM
a02a6e961100	b6cb52e645de	7e789be24511 a6b87853cb21	Lukas Tönne	Merge branch 'master' into compo_structural_cleanup (Show More…)	Feb 19 2014, 10:53 AM
7e789be24511	cb804a0d2a32	15ac49830ea5	Lukas Tönne	Pruning unreachable operations: This removes up any operations that will never… (Show More…)	Feb 17 2014, 9:01 AM
15ac49830ea5	fcc5b77b9e2f	c82f70a568bb	Lukas Tönne	Bring back node groups, by adding a method to resolve proxy operations. (Show More…)	Feb 16 2014, 6:59 PM
c82f70a568bb	cfbf4a39c3a9	01c4fc7ce371	Lukas Tönne	determineResolutions has to be done before add read/write buffer operations… (Show More…)	Feb 16 2014, 5:14 PM
01c4fc7ce371	cb6b535c5907	c9daa2233992	Lukas Tönne	determineResolutions should be performed before grouping operations. (Show More…)	Feb 16 2014, 4:16 PM
c9daa2233992	b37b9cd755a7	ec52e8414a69	Lukas Tönne	Fix for DebugInfo accessing deprecated function.	Feb 16 2014, 4:07 PM
ec52e8414a69	0b657bb5c454	6eb1eb247bca	Lukas Tönne	Sanity for the ExecutionGroup::addOperation function. (Show More…)	Feb 16 2014, 2:18 PM
6eb1eb247bca	1aa3ae880c5d	dd357d897c68	Lukas Tönne	Divided the NodeCompiler class into a basic abstract interface and an… (Show More…)	Feb 16 2014, 11:09 AM
dd357d897c68	1cdb1934b6d7	313a27cc81e9	Lukas Tönne	Fixed stub DebugInfo functions when COM_DEBUG is disabled.	Feb 16 2014, 9:48 AM
313a27cc81e9	a9ff354c0fc2	f810df3d6e0b	Lukas Tönne	Changed primary graphviz layout direction to LR, this works a bit better.	Feb 16 2014, 9:45 AM
f810df3d6e0b	f3a5eea52d54	7f8b7060120e	Lukas Tönne	Fixed DebugInfo class implementation for COM_DEBUG mode and graphviz dump.	Feb 16 2014, 9:42 AM
7f8b7060120e	39c531911fc5	fb8759879840	Lukas Tönne	Made a couple of info functions const.	Feb 16 2014, 8:58 AM
fb8759879840	a3229847cd8a	0a51d8028d7a	Lukas Tönne	Fix for Blur operations: use a copy of the NodeBlurData instead of keeping a… (Show More…)	Feb 15 2014, 1:35 PM
0a51d8028d7a	a4028a81c01d	3d322656be4c	Lukas Tönne	Made NodeLink an internal class of the NodeGraph (mirroring usage of OpLink in… (Show More…)	Feb 15 2014, 1:19 PM
3d322656be4c	89cecc0e6d89	eba8cadba0f0	Lukas Tönne	Changed the type of the m_connection in NodeInput to a direct NodeOutput… (Show More…)	Feb 15 2014, 1:07 PM
eba8cadba0f0	cab0f2bb7a04	528e0fae8233	Lukas Tönne	Removed connections list from the NodeOutput sockets. (Show More…)	Feb 15 2014, 1:02 PM
528e0fae8233	00b1e3036e50	75c74847b84f	Lukas Tönne	Removed the utility functions for mapping all inputs/outputs of a node at once… (Show More…)	Feb 15 2014, 12:29 PM
75c74847b84f	404cd1d5cdb8	d6cbb8471afd	Lukas Tönne	Fix for datatype conversion, the converter operation wasn't added to the list.	Feb 15 2014, 11:35 AM
d6cbb8471afd	807d18aa6c86	83bc65b35d82	Lukas Tönne	Insert datatype conversion operations separately from the NodeLink compiling. (Show More…)	Feb 15 2014, 11:30 AM
83bc65b35d82	7d4d43ea2b20	ffce41a3bdc7	Lukas Tönne	Made the m_links vector in NodeCompiler a direct container of OpLink instead of… (Show More…)	Feb 15 2014, 10:34 AM
ffce41a3bdc7	844bcc58d742	de226de0503e	Lukas Tönne	Removed OpLink list from ExecutionSystem. (Show More…)	Feb 15 2014, 10:06 AM
de226de0503e	525aceb18013	3a3dd673001b	Lukas Tönne	Store the connected output socket in OpInput directly instead of the… (Show More…)	Feb 15 2014, 9:41 AM
3a3dd673001b	41257a4425e3	7a4240fe84ac	Lukas Tönne	Removed connections lists from OpOutput. (Show More…)	Feb 15 2014, 9:15 AM
7a4240fe84ac	de76e4951b05	56ea33a21430	Lukas Tönne	Removed unused functions for operation/connection/group access from the… (Show More…)	Feb 14 2014, 8:56 PM
56ea33a21430	9e06047df9bc	a63440a35d22	Lukas Tönne	Added copy function for transferring data from the NodeCompiler to the final… (Show More…)	Feb 14 2014, 8:52 PM
a63440a35d22	f844f68d9209	442c90aca729	Lukas Tönne	Fix for invalidated iterator: cache links that need conversion before adding… (Show More…)	Feb 14 2014, 8:51 PM
442c90aca729	4370cf00c138	7cf0ac596b1e	Lukas Tönne	Fix for invalidating iterator: Cache unconnected inputs before adding default… (Show More…)	Feb 14 2014, 8:47 PM
7cf0ac596b1e	8f87370f9723	fe99011375a0	Lukas Tönne	Moved the determineResolutions function into the NodeCompiler.	Feb 14 2014, 7:49 PM
fe99011375a0	b960ea3ebb15	16c1e89c259e	Lukas Tönne	Removed the ExecutionSystemHelper class. (Show More…)	Feb 14 2014, 7:35 PM
16c1e89c259e	5218f3128007	231fa60c0352	Lukas Tönne	Moved functions for creating read/write buffer ops and for grouping operations… (Show More…)	Feb 14 2014, 7:21 PM
231fa60c0352	c89e710b2a82	8daeb6a05f10	Lukas Tönne	NodeCompiler now stores its own list of operations and links. (Show More…)	Feb 14 2014, 5:43 PM
8daeb6a05f10	e2807ec1b671	f84b583c211b	Lukas Tönne	Changed the compiler and context arguments of the convertToOperations method… (Show More…)	Feb 14 2014, 4:40 PM
f84b583c211b	a9093146eb55	d535df8e34bd	Lukas Tönne	Some cleanup and typedefs for STL container types.	Feb 13 2014, 5:08 PM
d535df8e34bd	70ae90ab7fc8	bc777c64fb09	Lukas Tönne	Renamed OpConnection to OpLink.	Feb 13 2014, 3:18 PM
bc777c64fb09	e16be073d827	563e96b7937f	Lukas Tönne	Renamed SocketConnection to NodeLink.	Feb 13 2014, 3:16 PM
563e96b7937f	d179110d6de0	433ffff74259	Lukas Tönne	Moved the SocketConnection class into the NodeGraph file. (Show More…)	Feb 13 2014, 3:08 PM
433ffff74259	222166c0af9e	380a56d5a44f	Lukas Tönne	Renamed node socket classes: (Show More…)	Feb 13 2014, 3:00 PM
380a56d5a44f	c1a481086d16	b601c10eb778	Lukas Tönne	Use the InputSocket/OutputSocket constructors for initializing variables… (Show More…)	Feb 13 2014, 2:44 PM
b601c10eb778	5d72f2b6cdb8	8033d79616e8	Lukas Tönne	Copy constructors for sockets are not needed or used.	Feb 13 2014, 2:30 PM
8033d79616e8	1af4a53c7f06	9e3543b9d5d4	Lukas Tönne	Removed deprecated and unused isInputSocket/isOutputSocket functions.	Feb 13 2014, 2:29 PM
9e3543b9d5d4	b12eb991ddb0	b137f51dcd40	Lukas Tönne	Removed the Socket shared based class for InputSocket and OutputSocket. (Show More…)	Feb 13 2014, 2:24 PM
b137f51dcd40	107d1451f934	457b2c65c575	Lukas Tönne	Moved the InputSocket and OutputSocket classes (as well as the current shared… (Show More…)	Feb 13 2014, 2:05 PM
457b2c65c575	e814b7324d1f	4daedde0e589	Lukas Tönne	Renamed NodeOperation to just Operation. (Show More…)	Feb 12 2014, 4:56 PM
4daedde0e589	870733b7342b	06c4a87103b4	Lukas Tönne	Moved the OpConnection class into the ExecutionSystem files. (Show More…)	Feb 12 2014, 2:37 PM
06c4a87103b4	20e079d8a034	85dc63e5e0ab	Lukas Tönne	Removed the NodeBase class, which is now devoid of any functionality and was… (Show More…)	Feb 12 2014, 2:23 PM
85dc63e5e0ab	69cb5e6ffe4e	05eda2c2732e	Lukas Tönne	Moved the bNodeTree/bNode pointers from NodeBase over to Node. (Show More…)	Feb 12 2014, 2:11 PM
05eda2c2732e	734bcd204ae4	603e97796f22	Lukas Tönne	Removed isOperation method from nodes. (Show More…)	Feb 12 2014, 1:48 PM
603e97796f22	d440b4a2281a	1b19f1de609f	Lukas Tönne	Removed leftover findAttachedWriteBufferOperation from OutputSocket, only… (Show More…)	Feb 12 2014, 1:46 PM
1b19f1de609f	f9a78b7c8808	f4f82886a4ac	Lukas Tönne	Removed disused getStaticValues method.	Feb 12 2014, 1:45 PM
f4f82886a4ac	c09c7b430fd4	4ac3b9e253bd	Lukas Tönne	Removed the disused isStatic method from NodeBase/Node/InputSocket. (Show More…)	Feb 12 2014, 1:43 PM
4ac3b9e253bd	90ad9a8feb11	b965ae66ddfc	Lukas Tönne	Removed determineResolution method from the OutputSocket class, this is no… (Show More…)	Feb 12 2014, 1:39 PM
b965ae66ddfc	883cd389a6d5	209ceb9c426d	Lukas Tönne	Added new OpInput and OpOutput classes as well as a OpConnection class to… (Show More…)	Feb 12 2014, 1:35 PM
209ceb9c426d	082b733b10e5	7255cfc219fc	Lukas Tönne	Moved the socket lists from NodeBase into Node, so we can use separate… (Show More…)	Feb 12 2014, 8:35 AM
7255cfc219fc	20b72c4c1b92	527fd18ef8d1	Lukas Tönne	Added new socket and connection classes to replace the shared classes and… (Show More…)	Feb 11 2014, 6:21 PM
527fd18ef8d1	9aa32b963cc1	257d7d1922e8	Lukas Tönne	Structural cleanup for the compositor (Show More…)	Feb 11 2014, 12:44 PM
257d7d1922e8	e8cae3a61234	62a2b6d07969	Lukas Tönne	Moved the NodeGraph class into its own file.	Feb 11 2014, 10:19 AM
62a2b6d07969	17d73eb6d819	739f2bc90109	Lukas Tönne	Moved socket registration for connections out of the connection… (Show More…)	Feb 11 2014, 10:02 AM
739f2bc90109	ae56f71eec3c	2343d0bce20a	Lukas Tönne	Removed deprecated sanity assert. (Show More…)	Feb 11 2014, 9:25 AM
2343d0bce20a	6fec3308bebc	2cdafc8a57b9	Lukas Tönne	Finished first step of converting all the nodes to the new NodeCompiler… (Show More…)	Feb 11 2014, 9:17 AM
2cdafc8a57b9	be3e4331da2e	11ab073f3935	Lukas Tönne	Another intermediate commit, more nodes updated.	Feb 10 2014, 2:14 PM
11ab073f3935	84e231bbdbc2	d04e266d7a2b	Lukas Tönne	Support for multiple mappings of operations to node inputs. (Show More…)	Feb 9 2014, 10:11 AM
d04e266d7a2b	c21b968d1cc2	42946c37c789	Lukas Tönne	Intermediate commit: most basic code cleanup up, mostly monkey work now.	Feb 8 2014, 7:25 PM

Structural cleanup for the compositorAbandonedPublicActions

Details

Layered structure

Dedicated classes: What happens Where

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 1303

source/blender/compositor/CMakeLists.txt

source/blender/compositor/COM_compositor.h

source/blender/compositor/COM_defines.h

source/blender/compositor/intern/COM_CPUDevice.cpp

source/blender/compositor/intern/COM_ChannelInfo.h

source/blender/compositor/intern/COM_CompositorContext.h

source/blender/compositor/intern/COM_Converter.h

source/blender/compositor/intern/COM_Converter.cpp

source/blender/compositor/intern/COM_Debug.h

source/blender/compositor/intern/COM_Debug.cpp

source/blender/compositor/intern/COM_ExecutionGroup.h

source/blender/compositor/intern/COM_ExecutionGroup.cpp

source/blender/compositor/intern/COM_ExecutionSystem.h

source/blender/compositor/intern/COM_ExecutionSystem.cpp

source/blender/compositor/intern/COM_ExecutionSystemHelper.h

source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp

source/blender/compositor/intern/COM_InputSocket.h

source/blender/compositor/intern/COM_InputSocket.cpp

source/blender/compositor/intern/COM_MemoryBuffer.h

source/blender/compositor/intern/COM_MemoryBuffer.cpp

source/blender/compositor/intern/COM_MemoryProxy.h

source/blender/compositor/intern/COM_Node.h

source/blender/compositor/intern/COM_Node.cpp

source/blender/compositor/intern/COM_NodeBase.h

source/blender/compositor/intern/COM_NodeBase.cpp

source/blender/compositor/intern/COM_NodeConverter.h

source/blender/compositor/intern/COM_NodeConverter.cpp

source/blender/compositor/intern/COM_NodeGraph.h

source/blender/compositor/intern/COM_NodeGraph.cpp

source/blender/compositor/intern/COM_NodeOperation.h

source/blender/compositor/intern/COM_NodeOperation.cpp

source/blender/compositor/intern/COM_NodeOperationBuilder.h

source/blender/compositor/intern/COM_NodeOperationBuilder.cpp

source/blender/compositor/intern/COM_OpenCLDevice.h

source/blender/compositor/intern/COM_OpenCLDevice.cpp

source/blender/compositor/intern/COM_OutputSocket.h

source/blender/compositor/intern/COM_OutputSocket.cpp

source/blender/compositor/intern/COM_SingleThreadedNodeOperation.h

source/blender/compositor/intern/COM_SingleThreadedNodeOperation.cpp

source/blender/compositor/intern/COM_SingleThreadedOperation.h

source/blender/compositor/intern/COM_SingleThreadedOperation.cpp

source/blender/compositor/intern/COM_Socket.h

source/blender/compositor/intern/COM_Socket.cpp

source/blender/compositor/intern/COM_SocketConnection.h

source/blender/compositor/intern/COM_SocketConnection.cpp

source/blender/compositor/intern/COM_WorkScheduler.cpp

source/blender/compositor/nodes/COM_AlphaOverNode.h

source/blender/compositor/nodes/COM_AlphaOverNode.cpp

source/blender/compositor/nodes/COM_BilateralBlurNode.h

source/blender/compositor/nodes/COM_BilateralBlurNode.cpp

source/blender/compositor/nodes/COM_BlurNode.h

source/blender/compositor/nodes/COM_BlurNode.cpp

source/blender/compositor/nodes/COM_BokehBlurNode.h

source/blender/compositor/nodes/COM_BokehBlurNode.cpp

source/blender/compositor/nodes/COM_BokehImageNode.h

source/blender/compositor/nodes/COM_BokehImageNode.cpp

source/blender/compositor/nodes/COM_BoxMaskNode.h

source/blender/compositor/nodes/COM_BoxMaskNode.cpp

source/blender/compositor/nodes/COM_BrightnessNode.h

source/blender/compositor/nodes/COM_BrightnessNode.cpp

source/blender/compositor/nodes/COM_ChannelMatteNode.h

source/blender/compositor/nodes/COM_ChannelMatteNode.cpp

source/blender/compositor/nodes/COM_ChromaMatteNode.h

source/blender/compositor/nodes/COM_ChromaMatteNode.cpp

source/blender/compositor/nodes/COM_ColorBalanceNode.h

source/blender/compositor/nodes/COM_ColorBalanceNode.cpp

source/blender/compositor/nodes/COM_ColorCorrectionNode.h

source/blender/compositor/nodes/COM_ColorCorrectionNode.cpp

source/blender/compositor/nodes/COM_ColorCurveNode.h

source/blender/compositor/nodes/COM_ColorCurveNode.cpp

source/blender/compositor/nodes/COM_ColorMatteNode.h

Structural cleanup for the compositor
AbandonedPublic
Actions

Revision Contents
Changeset List