Page MenuHome

Freestyle: use depsgraph to get geometry, instead of Blender Internal.
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Apr 4 2018, 6:09 PM.

Details

Summary

This is a necessary step before we can remove Blender Internal in 2.8. I only
tested the basics, not yet all the Freestyle features.

Some of the code is simpler because we use Blender's triangulation directly
instead of dealing with quads. Also some progress printing code was removed
because the depsgraph can not tell us the number of objects ahead of time.

Diff Detail

Repository
rB Blender

Event Timeline

Fix bug with edge marks.

I added two Cycles Freestyle regression tests now, which include smooth/flat faces, edge marks, face marks, and metaballs to test non-mesh datablocks.

OldNew

There's some differences due to the different triangulation. The new result looks better to me, fixing some gaps in the stroke. Generally it's good to follow the Cycles and Eevee triangulation to ensure consistent results.

As far as I'm concerned this is ready to review and then commit to 2.8.

Many thanks to Brecht for the revision! It works just fine as far as I tested.

This revision is now accepted and ready to land.Apr 8 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.