Page MenuHome

Triangulate modifier port to 2.8
ClosedPublic

Authored by Christian Hubert (alikendarfen) on May 8 2018, 10:15 AM.

Details

Summary

It seems to be ok, but please have a look to "BKE_mesh_to_bmesh" (line 47) and "BKE_bmesh_to_mesh" (line 51), because I'm not sure to give them the good parameters.

Diff Detail

Repository
rB Blender

Event Timeline

Several correction in order to follow the instructions given for boolean (code change the less possible).

Using BKE_mesh_to_bmesh_ex, formatting, ordering of includes.

There were some issues, which I fixed myself. Thanks for your contribution!

source/blender/modifiers/intern/MOD_triangulate.c
33–34

This #include is no longer necessary.

37

Keep the #includes grouped, so add DNA_xxx files to the already-existing #include "DNA_xxx" statements.

49–52

The DM_to_bmesh call also calculated normals, which your code does not.
Using BKE_mesh_to_bmesh_ex here would make more sense.

This revision is now accepted and ready to land.May 9 2018, 4:13 PM
This revision was automatically updated to reflect the committed changes.