Page MenuHome

Multi-Object-Editing Support for MESH_OT_beautify_fill
ClosedPublic

Authored by Remi van der Laan (ThaRemo) on May 9 2018, 11:23 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Dalai Felinto (dfelinto) requested changes to this revision.May 9 2018, 12:26 PM

Hi, thanks for your patch. There are a few things that need to change though:

source/blender/editors/mesh/editmesh_tools.c
4288

Move the { to the previous line with a space between the parenthesis and the brackets. It is only in different lines in the example commit to keep the example file simpler (so no indentation was changed there).

4293

No const need to be in the for loop unless related to the object in question.

4316

Don't use tabs here, use spaces instead (for the padding relative to the "if" line).

4321

Only separate the if/else from the bracket if it is a multi-line if/else statement.

This revision now requires changes to proceed.May 9 2018, 12:26 PM

Thanks for the feedback! I'll have a good look at the coding style before a next contribution...
I think the code should be okay now though

Fixed white-space on line 4306

Re-added space after BM_ITER_MESH and kept the continue in EDBM_op_call_and_selectf for consistency

More coding style improvements

This revision was not accepted when it landed; it landed in state Needs Review.May 9 2018, 1:48 PM
This revision was automatically updated to reflect the committed changes.

All good now. Actually I forgot to tell you to include a test for selected faces. I did that change in the final commit, check the commit to see the differences.
Thanks for your contribution.