Page MenuHome

Multi object edit: Added MESH_OT_vert_connect_path
AbandonedPublic

Authored by Falk David (filedescriptor) on May 9 2018, 1:35 PM.

Diff Detail

Event Timeline

Dalai Felinto (dfelinto) requested changes to this revision.May 9 2018, 1:52 PM

This one is tricky because edbm_vert_connect_exec also loops over all the objects.

My suggestion, move the logic to handle vert_connect to its own function, and make it accessible by both operators.
And you don't really want to break if one of the vert_connect calls fail.

This revision now requires changes to proceed.May 9 2018, 1:52 PM

I see. I'll have some time this afternoon and then I will try and see what I can do.
And yes, thinking about it, the break is unnecessary.

I have created a new function bm_connect_vert_pair (other name suggestions are welcome!) that basically does the same as edbm_vert_connect_exec before multi object edit. Then I used it in the new edbm_vert_connect_exec and also edbm_vert_connect_path_exec so that each operator only loops through the objects once.

Dalai Felinto (dfelinto) requested changes to this revision.May 11 2018, 11:53 AM

Applying the patch is failing at the moment, could you please rebase with blender2.8 and re-submit using arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

This revision now requires changes to proceed.May 11 2018, 11:53 AM

It didnt seem to update this diff but instead created a new one D3349

I will abandon this then. For the records you could have updated it with arc diff origin/blender2.8 --update D3293.

OK, thank you for the info!