Page MenuHome

Laplacian deform port to 2.8
ClosedPublic

Authored by Christian Hubert (alikendarfen) on May 10 2018, 6:48 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested changes to this revision.May 11 2018, 3:09 PM
Sybren A. Stüvel (sybren) added inline comments.
source/blender/modifiers/intern/MOD_laplaciandeform.c
47

Add new includes in alphabetical order.

549

Use BKE_mesh_runtime_looptri_len to get the number of looptris.

560–561

Use BKE_mesh_runtime_looptri_len to get the number of looptris.

567–568

Use BKE_mesh_runtime_looptri_ensure to get the array.

735

Rename mesh to mesh_src and meshData to mesh, to be consistent with the other modifiers.

745

Rename mesh to mesh_src and meshData to mesh, to be consistent with the other modifiers.

747–748

Use get_mesh to get the mesh.

This revision now requires changes to proceed.May 11 2018, 3:09 PM

Changes:

  • Includes in alphabetical order
  • Usage of BKE_mesh_runtime_looptri_len and BKE_mesh_runtime_looptri_ensure
  • Rename mesh to mesh_src and meshData to mesh, to be consistent with the other modifiers

The binding operator doesn't work with copy-on-write yet, so you can't use this modifier on new objects yet. I'll work on this, as I've also done a similar approach for the Surface Deform modifier.

  • Make the bind operator work with CoW
This revision was not accepted when it landed; it landed in state Needs Review.May 11 2018, 6:10 PM
This revision was automatically updated to reflect the committed changes.