Page MenuHome

Multi object edit - UV_OT_pin
AbandonedPublic

Authored by Alan Troth (Al) on May 16 2018, 5:35 PM.

Details

Diff Detail

Repository
rB Blender
Branch
UV_OT_pin (branched from blender2.8)
Build Status
Buildable 1638
Build 1638: arc lint + arc unit

Event Timeline

Replaced

BKE_view_layer_array_from_objects_in_edit_mode_unique_data(

with

BKE_view_layer_array_from_objects_in_edit_mode_unique_data_with_uvs(

.

Also I sugest you to use Arcanist for your diffs it will be esasier for you to do changes:
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

source/blender/editors/uvedit/uvedit_ops.c
3672

MEM_freeN(objects);

3672

MEM_freeN(objects);

Added the freeing of '**objects'.

source/blender/editors/uvedit/uvedit_ops.c
3683–3684

Should only add notifier if a change is made.

Campbell Barton (campbellbarton) requested changes to this revision.May 18 2018, 2:01 PM
This revision now requires changes to proceed.May 18 2018, 2:01 PM

Added code so WM_event_add_notifier(..) is only called for an object when the pinned status of any of its uvs changes.

Alan Troth (Al) marked 3 inline comments as done.May 19 2018, 1:18 AM

Thanks for the patch.
I committed a different version on rB0f50caf5560f9c2f9af393eefdf2b209210dbfba.