Cycles: Add option to make lamps directly visible to the camera
Needs RevisionPublic

Authored by Lukas Stockner (lukasstockner97) on May 24 2018, 10:53 PM.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3433
Build Status
Buildable 1702
Build 1702: arc lint + arc unit
Brecht Van Lommel (brecht) requested changes to this revision.May 26 2018, 3:47 PM

For meshes and world this is controlled through Ray Visibility > Camera.

I think we use the same terminology, and maybe just make the existing ray visibility setting on the object work? The tricky part is that's it's not possible for custom properties to have a different default for lamp objects, though I guess we can work around that by having a different property for lamps that still shows with the same name in the UI?

This revision now requires changes to proceed.May 26 2018, 3:47 PM

Yes, that definitely is a better place for it.

Brecht Van Lommel (brecht) requested changes to this revision.May 28 2018, 12:00 AM

Enabling this seems to make all lamps in the scene visible? I think we should set SHADER_EXCLUDE_CAMERA for lamps and then handle it in indirect_lamp_emission?

intern/cycles/blender/addon/properties.py
1011

Spelling: separate

intern/cycles/render/light.cpp
137

Can we rename this to use_camera too?

This revision now requires changes to proceed.May 28 2018, 12:00 AM