Page MenuHome

Multi object editing - UV_OT_remove_doubles
AbandonedPublic

Authored by Alan Troth (Al) on May 27 2018, 2:11 PM.

Diff Detail

Repository
rB Blender
Branch
blender2.8
Build Status
Buildable 2022
Build 2022: arc lint + arc unit

Event Timeline

  • Removed white space.
  • Function name changes.
  • Removed unused code.
Dalai Felinto (dfelinto) requested changes to this revision.Sep 5 2018, 4:59 PM

This produces a really, really strange result when "unselected" is false. Try to run with either monkey from this file:

Just compare a single object before and after the patch to see the issue.

This revision now requires changes to proceed.Sep 5 2018, 4:59 PM
  • Bug fix - don't add own uv twice.

Skip loop when no vertex is selected and code style.

Many thanks for this patch. Committed on rB85c9765d820c069cca2c7166d1726d30c8d4aa00 with minor changes.
It took me some time to understand what you are doing (the while (ob_mloopuv_max_idx[ob_index] < i) loop in particular) but good job, all seem to be working now.

@Campbell Barton (campbellbarton) this is a big one that landed already. Feel free to audit it and do eventual changes.