Page MenuHome

Multi object editing for UV_OT_lightmap_pack.
AbandonedPublic

Authored by Alan Troth (Al) on Jun 1 2018, 10:11 PM.

Diff Detail

Repository
rB Blender
Branch
UV_OT_lightmap_pack (branched from blender2.8)
Build Status
Buildable 1809
Build 1809: arc lint + arc unit

Event Timeline

release/scripts/startup/bl_operators/uvcalc_lightmap.py
562–577

Should be ...active.mode == 'EDIT'. I'll fix it when I can.

  • Corrected variable name.
Alan Troth (Al) marked an inline comment as done.Jun 27 2018, 8:24 PM
Alan Troth (Al) updated this revision to Diff 11374.EditedJul 7 2018, 4:10 PM
  • Convert to blender2.8.
  • Updated selection options.
    • 'Selected Faces' and 'All Faces' now apply to all objects, not just the active one.

I see what you did here, but I think we should embrace multi-objects a bit further.
Honestly I think we could even ditch the all faces/selected faces option altogether, but I don't want to be that much disruptive.

See:

Any thoughts? (@Campbell Barton (campbellbarton) any thoughts too?)

Alan Troth (Al) added a comment.EditedSep 6 2018, 12:18 AM

Any thoughts? (@Campbell Barton (campbellbarton) any thoughts too?)

I think some users may find not having to go into edit-mode to do uv unwrapping convenient, is there any disadvantage to keeping it? If object-mode uwrapping is kept for lightmap_pack, then to be consistent across the UI, other unwrapping operators should also get a similar object-mode unwrap option.

While in edit-mode, only selected faces should be unwrapped (consistent with other uv unwrap operators).

In object-mode unwrapping should apply to all faces of all objects.