Page MenuHome

Image: Refactor render slots to a dynamic list
ClosedPublic

Authored by Lukas Stockner (lukasstockner97) on Jun 12 2018, 2:36 PM.

Details

Summary

Previously, render slots were hardcoded to a fixed amount.

With this change, render slots now are stored in a list. Therefore, users can add and/or remove as many slots as they want.

Diff Detail

Repository
rB Blender

Event Timeline

  • Add Render Slots panel with list widget and +/-/x icons.
  • Only create render slots for render result images.
  • Always initialize slot names.
Brecht Van Lommel (brecht) requested changes to this revision.Jun 14 2018, 5:49 PM

Updated with some UI tweaks.

One bug I found is that clear a slot while it is being render to crashes.

Otherwise this looks good to commit.

This revision now requires changes to proceed.Jun 14 2018, 5:49 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Jun 14 2018, 10:56 PM
This revision was automatically updated to reflect the committed changes.

This is a fantastic improvement, great work.
It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.

I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

This is a fantastic improvement, great work.
It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.
I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

Definitely!

It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.
I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

There's a proposal for that kind of thing here:
https://devtalk.blender.org/t/new-slots-system-in-render-view/731/13