Page MenuHome

Add font selection to VSE text strips
Needs ReviewPublic

Authored by Richard Antalik (ISS) on Aug 17 2018, 10:37 PM.

Details

Summary

Continuation of https://developer.blender.org/D2424

Allows users to select a font for their text strips in the video sequence editor.

Diff Detail

Event Timeline

source/blender/blenfont/intern/blf_dir.c
145

technically can pass bmain in one instance, otherwise would have to pass NULL explicitly and skip path cleanup

source/blender/windowmanager/intern/wm_event_system.c
1345–1358

introduced by Campbell. This does change target area, when clicking on unlink button, raising error.

This has been a request for ages! Do you think you can make sure the patch works against the latest? A lot has changed since August. It will make it easier for developers to review.

Richard Antalik (ISS) added a comment.EditedNov 9 2018, 9:04 AM

This has been a request for ages! Do you think you can make sure the patch works against the latest? A lot has changed since August. It will make it easier for developers to review.

Hello Pablo,

Tomorrow I will rebase this patch on top of master. It should apply however.

I had trouble building 2.8 branch(not sure if it is better to send patches for master or 2.8).

If you can please push Campbell to have a look at my inline comment, as I have changed stuff in wm_event_system.c that I have no understanding of what it does / what it is good for.

This has been a request for ages! Do you think you can make sure the patch works against the latest? A lot has changed since August. It will make it easier for developers to review.

confirming, that this patch does apply against master.