Page MenuHome

Compositor: Film-like curve
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Aug 22 2018, 10:03 PM.

Details

Summary

Film-like curves for the RGB Curve node (Compositor) and Curve Modifier
(Sequencer)

Film-like curves originated from Adobe.
"It’s an RGB curve where the tone curve is applied on the largest and smallest value, and then the middle value is adapted to keep a constant hue as defined by RGB-HSL/HSV. In terms of look and saturation increase it’s very similar to a pure RGB curve, more so than a HSL-L curve or HSV-V curve, but some color shift problems are avoided."

Other tools like Natron, Krita and RawTherapee have implemented this curve tone.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Aug 23 2018, 1:30 AM

Looks generally fine. For release notes / documentation I guess this can be summarised as:

Film Like curve mapping is used for adjusting saturation and contrast, while avoiding color shifts. It does this by balancing the color channels to preserve the hue.

source/blender/blenkernel/intern/colortools.c
941

No need to use inline, just let the compiler decide. It's not obvious that inlining this function will actually give better performance.

989

Code style:

}
else if(..) {
source/blender/makesrna/intern/rna_color.c
121–122

We do not call modifiers from _set() functions, this should be in a separate _update() function.

This revision now requires changes to proceed.Aug 23 2018, 1:30 AM
Jeroen Bakker (jbakker) marked 3 inline comments as done.

Updated patch with comments from @Brecht Van Lommel (brecht)'s review

This revision is now accepted and ready to land.Aug 23 2018, 10:44 AM
This revision was automatically updated to reflect the committed changes.