Page MenuHome

Multi object support for UV live unwrap.
AbandonedPublic

Authored by Alan Troth (Al) on Aug 29 2018, 8:34 PM.

Details

Summary

Multi object support for UV live unwrap.

Note, I had to force 'if (tc->is_active) (in 'transform_conversions.c line 3200) to true to test the code as I couldn't see anywhere where 'is_active' is set to true in the code.

The patch will be a little easier to test if the patch for multi object version of UV_OT_pin has benn applied.

Diff Detail

Repository
rB Blender
Branch
live_uv_unwrap (branched from blender2.8)
Build Status
Buildable 1982
Build 1982: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested changes to this revision.Sep 6 2018, 12:40 AM

@Campbell Barton (campbellbarton) any thoughts on the use of static variables here?

source/blender/editors/uvedit/uvedit_unwrap_ops.c
924

codestyle: can you drop the CamelCase? We use it for classes only, for variables we stick to lowercase.

950

code style: only put the { in a new line if this is a two-line if statement.

The exception is here:
https://wiki.blender.org/wiki/Source/Code_Style#Exceptions_to_Braces_on_Same_Line

This revision now requires changes to proceed.Sep 6 2018, 12:40 AM

By the way, are you ever on IRC? If so you go by which handle (I'm dfelinto there)?

@Dalai Felinto (dfelinto) - we could avoid static variable use, but in practice for this case it's OK as far as I can see.

Campbell Barton (campbellbarton) accepted this revision.EditedSep 6 2018, 12:47 PM

Committed rBc89791ba788da65bc0ebe57af3a1dfa754d77863 with edits.

The is_active check isn't needed if we're live-unwrapping everything.