Page MenuHome

Mantaflow [Part 5]: Update other /intern packages
Needs ReviewPublic

Authored by Sebastián Barschkis (sebbas) on Oct 29 2018, 5:20 PM.

Diff Detail

Repository
rB Blender
Branch
internUpdate (branched from master)
Build Status
Buildable 4649
Build 4649: arc lint + arc unit

Event Timeline

Update manta files after merge with master.

Harbormaster completed remote builds in B3295: Diff 14646.
Bastien Montagne (mont29) added inline comments.
intern/CMakeLists.txt
43–45 ↗(On Diff #14646)

Again, to be removed?

intern/smoke/CMakeLists.txt
96–97

Just remove this then. :)

not much to say here, looks good but think at least @Brecht Van Lommel (brecht) will want to check on that one too.

The code logic seems fine since it's just a copy of the fluid stuff. The naming is weird in that it refers to smoke while we are dealing with mesh surfaces, but I guess that has already been brought up in the other code reviews.

Updated diff with latest changes from fluid-mantaflow branch