Page MenuHome

UI: Draw curve map with solid color
ClosedPublic

Authored by Charlie Jolly (charlie) on Nov 2 2018, 7:57 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Interesting. Why is it only half filled-in?

It’s split to show the difference with the current design. I’ve always found the old design difficult to read.

It’s split to show the difference with the current design. I’ve always found the old design difficult to read.

Wow I totally thought you were actually representing the Factor value of the node with how much "filled" it was. Maybe the opacity of the fill could be the factor. So current design would be when Factor 0, fully opaque when Factor 1.0 or when a node is connected to the Factor input.

Lapineige added a subscriber: Lapineige.EditedNov 3 2018, 12:17 PM

@venomgfx that's sounds very interesting, as it allows the curves to be much more readable and provide an extra information that is intuitively visible.
But if the factor is very low, would it still be visible that the node is active ? (Will there be enough contrast ?)

Factor is varying when connected so it's not possible to change the fill based on the factor.

This revision is now accepted and ready to land.Nov 3 2018, 2:33 PM
Brecht Van Lommel (brecht) requested changes to this revision.Nov 3 2018, 2:37 PM

It's too difficult to see the grid behind the fill color, maybe the alpha should be reduced.

I would not try to visualize the factor.

This revision now requires changes to proceed.Nov 3 2018, 2:37 PM

@Brecht Van Lommel (brecht): Good point - makes sense to keep the grid clearly visible at all times.

Increase alpha to 128 approx 50%

This is OK I think.

This revision is now accepted and ready to land.Nov 3 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.
YAFU (YAFU) added a subscriber: YAFU (YAFU).EditedNov 3 2018, 6:54 PM

Hi.
Some opensource Photo RAW editor uses a soft light gray line in the outline of the curve, it draws Grid in dark gray. As here in Blender the grid is light gray, maybe a curve outline in some dark color helps better visualization?

@YAFU (YAFU) FYI, this commit doesn't change any of the colours as they are based on the underlying theme.

I can easily create a new patch to add the line too, it would add a few more drawing calls but I doubt this is an issue.

OK, I see. Thank you.