I wonder if a better approach would be to toggle prompt for all kinds of Deletion (Curves, Keys, etc), not only object.
Also, would be nice to have an option to toggle the Save prompt as well, maybe something more generic could be thought through for general prompts?
"Clean Keyframes" and "Clean Channels" are 2 separates tools, that are both not the same as "Delete Keyframes". So this popup is not a confirmation popup, because it let you choose between 3 choices.
Yes, but maybe the delete shortcuts could just call an actual deletion, and let the cleaning options to another shortcut or a menu. I think it might be nice to let the delete buttons actually delete things right away. Considering it's more frequent to call a simple delete, and that most of the time in any software it just deletes on keypress without asking you what you wanted to do when you pressed that button with "Delete" written on.
There are several prompts we could remove completely, in favour of showing a message in the Status Bar.
We've solved this problem already for things like the Remove Doubles tool, which already works this way.
There's no need for a Save popup menu with no options other than clicking. In fact, this is a usability issue, because users might think they have already saved when in fact they have only opened a dialog. I've seen users lose work because if this problem.
So, rather than showing this when you hit Save, which requires an extra click every time:
We should just save immediately and display a message in the Status Bar, like so:
The same goes for things like deleting. Rather than showing a popup that you need to dismiss, we could just use a warning color in the Status Bar with a message:
IMO this doesn't even need to become a preference, I think we should just make this change fully. It's both easier & faster, and with the message UI, we communicate to the user what is going on. We have too many obscure preferences - we should rather just solve things as well as possible.
- Making these kinds of actions spawn a Status Bar message similar to Remove Doubles. Use the Warning message type for destructive actions.
- Removing the preference.
I removed the option and I added the warning message. However, maybe is not a good idea to remove the save file dialog. You could easily overwrite a file with undesired changes and lose your data if you don't have save versions enabled. I think that adding a more descriptive message or showing it only if you have save versions disabled could be a better option.