Fix for transform_conversions.c::sort_trans_data(TransInfo *t) exiting before all TransDataContainers are sorted.
ClosedPublic
Actions

Authored by Alan Troth (Al) on Nov 26 2018, 12:04 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)

Summary

The current implementation of sort_trans_data() returns from the function after the first container has been sorted., other containers are left unsorted.

The new implementation sorts all containers.

I found this bug while looking in to why multi object edit proportional editing wasn't working as expected.

Diff Detail

Repository

rB Blender

Branch

sort_trans_data (branched from blender2.8)

Build Status

Buildable 2542
Build 2542: arc lint + arc unit

Event Timeline

Alan Troth (Al) created this revision.Nov 26 2018, 12:04 AM

Alan Troth (Al) edited the summary of this revision. (Show Details)Nov 26 2018, 12:10 AM

Alan Troth (Al) mentioned this in D3993: Fix transform_conversions.c::set_prop_dist(...) to check all selected vertices when finding nearest selected vertex..Nov 26 2018, 12:44 AM

Thanks! Committed rB2b07c31fcf77ae82c5ea980f4d6343ef55643746

This revision is now accepted and ready to land.Nov 26 2018, 4:23 AM

Campbell Barton (campbellbarton) mentioned this in rB2b07c31fcf77: Fix proportional edit-mode w/ multi-object editing.Nov 26 2018, 4:23 AM

Campbell Barton (campbellbarton) closed this revision.Nov 26 2018, 4:23 AM

Revision Contents
Changeset List

			Path	Packages
M			source/blender/editors/transform/transform_conversions.c (53 lines)

Commit	Tree	Parents	Author	Summary	Date
e4560bee64f7	39eeccd8a2be	24c383cfc476	Alan	Fix early exit from sort_trans_data.	Nov 23 2018, 12:52 AM

Diff 12660

View Options

source/blender/editors/transform/transform_conversions.c

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12660	24c383c		Nov 25 2018, 11:46 PM	★	★

Fix for transform_conversions.c::sort_trans_data(TransInfo *t) exiting before all TransDataContainers are sorted.ClosedPublicActions